Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strip exif data from uploaded images #87

Merged
merged 1 commit into from Oct 9, 2016

Conversation

Projects
None yet
2 participants
@vayan
Copy link
Contributor

vayan commented Oct 8, 2016

Using -strip cli options from ImageMagick

http://www.imagemagick.org/script/command-line-options.php#strip

Fix #85

@vayan vayan force-pushed the vayan:feature/strip-exif-data-from-images branch from 1a65d06 to 35de03f Oct 8, 2016

def self.file_styles(f)
if f.instance.image?
{
original: '100%',

This comment has been minimized.

@vayan

vayan Oct 8, 2016

Author Contributor

We need this, else paperclip doesn't touch the original file.

@Gargron

This comment has been minimized.

Copy link
Member

Gargron commented Oct 8, 2016

I don't think I have a test case specifically for this, did you try it out on localhost?

@vayan

This comment has been minimized.

Copy link
Contributor Author

vayan commented Oct 9, 2016

did you try it out on localhost?

Yeah I did, you mean you don't have tests for pictures upload ? I can add some if you want.

@Gargron

This comment has been minimized.

Copy link
Member

Gargron commented Oct 9, 2016

There is a test for uploading a picture, but it doesn't check if the transformations are OK. It also doesn't test WebMs, I wrote the tests by they run very slow so they're being skipped.

@Gargron Gargron merged commit 52d7f86 into tootsuite:master Oct 9, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

Nyoho pushed a commit to Nyoho/mastodon that referenced this pull request Apr 25, 2017

Merge pull request tootsuite#87 from vayan/feature/strip-exif-data-fr…
…om-images

Strip exif data from uploaded images

akihikodaki pushed a commit to kagucho/mastodon that referenced this pull request May 3, 2017

yipdw pushed a commit to yipdw/mastodon that referenced this pull request Jul 28, 2017

tomoasleep added a commit to tomoasleep/mastodon that referenced this pull request Oct 24, 2017

Kirishima21 pushed a commit to Kirishima21/mastodon that referenced this pull request Jun 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.