Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove meta label in settings column #8704

Merged
merged 2 commits into from Sep 25, 2018

Conversation

@rhoio
Copy link
Contributor

commented Sep 16, 2018

Problem: In localizations with longer words than english (for example German) the floated meta label beside push notifications messes up the layout of the settings column, see screenshot:

bildschirmfoto 2018-09-16 um 10 24 42

One could develop a layout solution which prevents this, but since the information in the label is not that essential (and on desktop computers even somewhat misleading since the notifications come from the browser and not the device), I think removal is the best option. Keep it simple:
bildschirmfoto 2018-09-16 um 10 26 59

@ykzts ykzts merged commit c6e765f into tootsuite:master Sep 25, 2018

11 checks passed

ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: check-i18n Your tests passed on CircleCI!
Details
ci/circleci: install Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.3 Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.4 Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.5 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.3 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.4 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.5 Your tests passed on CircleCI!
Details
ci/circleci: test-webui Your tests passed on CircleCI!
Details
codeclimate All good!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.