New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust Vagrant Configuration #8706

Merged
merged 1 commit into from Sep 16, 2018

Conversation

Projects
None yet
2 participants
@trev-dev
Contributor

trev-dev commented Sep 16, 2018

Heyo

This pull request adjusts the vagrant configuration slightly to improve the developer experience.

The following changes are made:

  1. Change the default dev domain name to mastodon.dev to mastodon.local
    Why : .dev domain names have begun to fail without additional configuration overhead in Chrome/Firefox. .local works fine out of the box. Also added helpful comments.
    See:
    https://ma.ttias.be/chrome-force-dev-domains-https-via-preloaded-hsts/
    https://stackoverflow.com/questions/47809632/i-can-no-longer-access-my-local-development-dev-websites-in-chrome-http-is
    https://www.theregister.co.uk/2017/11/29/google_dev_network/
    https://medium.engineering/use-a-dev-domain-not-anymore-95219778e6fd

  2. Add additional (commented out) CPU config options to increase Vagrant performance as needed

  3. Add actimeo=1 to config.vm.synced_folder in order to make hot-reloading work without having to sync clocks between host and vagrant guest.

Have a great week!

@trev-dev trev-dev referenced this pull request Sep 16, 2018

Closed

Dev Mode: Change mastodon.dev to something that works #8684

1 of 2 tasks complete

@nightpool nightpool merged commit 8971bb8 into tootsuite:master Sep 16, 2018

11 checks passed

ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: check-i18n Your tests passed on CircleCI!
Details
ci/circleci: install Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.3 Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.4 Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.5 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.3 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.4 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.5 Your tests passed on CircleCI!
Details
ci/circleci: test-webui Your tests passed on CircleCI!
Details
codeclimate All good!
Details
@nightpool

This comment has been minimized.

Collaborator

nightpool commented Sep 16, 2018

thanks!

Gargron added a commit that referenced this pull request Sep 17, 2018

Revert "Updated ruby/node images" (#8712)
* Revert "update vagrant configs (#8706)"

This reverts commit 8971bb8.

* Revert "Updated ruby/node images (#8700)"

This reverts commit 5aae71c.

kyori19 added a commit to kyori19/mastodon that referenced this pull request Sep 20, 2018

koppepan1204 pushed a commit to koppepan1204/mastodon that referenced this pull request Oct 10, 2018

koppepan1204 pushed a commit to koppepan1204/mastodon that referenced this pull request Oct 10, 2018

Revert "Updated ruby/node images" (tootsuite#8712)
* Revert "update vagrant configs (tootsuite#8706)"

This reverts commit 8971bb8.

* Revert "Updated ruby/node images (tootsuite#8700)"

This reverts commit 5aae71c.

koppepan1204 pushed a commit to koppepan1204/mastodon that referenced this pull request Oct 12, 2018

koppepan1204 pushed a commit to koppepan1204/mastodon that referenced this pull request Oct 12, 2018

Revert "Updated ruby/node images" (tootsuite#8712)
* Revert "update vagrant configs (tootsuite#8706)"

This reverts commit 8971bb8.

* Revert "Updated ruby/node images (tootsuite#8700)"

This reverts commit 5aae71c.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment