Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset status cache when status_stat or media_attachment updates #9119

Merged
merged 2 commits into from Oct 28, 2018

Conversation

@Gargron
Copy link
Member

commented Oct 27, 2018

Fix #8711

Media attachments are generally immutable, but admins can update
the sensitive flag, and this would ensure the change is visible
instantly. Same for updates to status stats. That is a regression
from #8185, because even the correct updated_at fetched from a join
doesn't seem to invalidate the cache.

Fix #8711

Media attachments are generally immutable, but admins can update
the sensitive flag, and this would ensure the change is visible
instantly. Same for updates to status stats. That is a regression
from #8185, because even the correct updated_at fetched from a join
doesn't seem to invalidate the cache.
@Gargron Gargron added the bug label Oct 27, 2018
@Gargron Gargron merged commit 11b3ee4 into master Oct 28, 2018
11 checks passed
11 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: check-i18n Your tests passed on CircleCI!
Details
ci/circleci: install Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.3 Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.4 Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.5 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.3 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.4 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.5 Your tests passed on CircleCI!
Details
ci/circleci: test-webui Your tests passed on CircleCI!
Details
codeclimate All good!
Details
@Gargron Gargron deleted the fix-status-cache-resets branch Oct 28, 2018
cyber-gene pushed a commit to ikebuku-ro/mastodon that referenced this pull request Oct 29, 2018
* 'master' of github.com:tootsuite/mastodon: (23 commits)
  Bump version to 2.6.0rc3 (tootsuite#9142)
  Update AUTHORS.md (tootsuite#9141)
  Bump sanitize from 4.6.6 to 5.0.0 (tootsuite#9140)
  Update i18n-tasks to master (tootsuite#9139)
  Improved grammar in German translation (tootsuite#9092)
  Add Page AP type support (tootsuite#9121)
  Weblate translations (2018-10-26) (tootsuite#9113)
  Bump parallel_tests from 2.25.0 to 2.26.0 (tootsuite#9137)
  Bump tzinfo-data from 1.2018.6 to 1.2018.7 (tootsuite#9136)
  Bump rubocop from 0.59.2 to 0.60.0 (tootsuite#9135)
  Bump doorkeeper from 5.0.1 to 5.0.2 (tootsuite#9134)
  Fix dimensions of preview cards, fix crash in web UI, fix warning (tootsuite#9133)
  Update i18n-tasks and change CircleCI command (tootsuite#9104)
  Reset status cache when status_stat or media_attachment updates (tootsuite#9119)
  Add progress indicators to MigrateAccountConversations (tootsuite#9101)
  Set z-index of dropdown to 9999. (tootsuite#9126)
  Include preview cards in status entity in REST API (tootsuite#9120)
  Do not remove "dead" domains in tootctl accounts cull (tootsuite#9108)
  When searching for an emoji with multiple separators, consider the full input (tootsuite#9124)
  Add locality check to ActivityPub::FetchRemoteAccountService (tootsuite#9109)
  ...
cyber-gene pushed a commit to ikebuku-ro/mastodon that referenced this pull request Oct 29, 2018
* commit 'e84da282f6331d463678a7e3ccd37e66c0dfcab3': (34 commits)
  Bump version to 2.6.0rc3 (tootsuite#9142)
  Update AUTHORS.md (tootsuite#9141)
  Bump sanitize from 4.6.6 to 5.0.0 (tootsuite#9140)
  Update i18n-tasks to master (tootsuite#9139)
  Improved grammar in German translation (tootsuite#9092)
  Add Page AP type support (tootsuite#9121)
  Weblate translations (2018-10-26) (tootsuite#9113)
  Bump parallel_tests from 2.25.0 to 2.26.0 (tootsuite#9137)
  Bump tzinfo-data from 1.2018.6 to 1.2018.7 (tootsuite#9136)
  Bump rubocop from 0.59.2 to 0.60.0 (tootsuite#9135)
  Bump doorkeeper from 5.0.1 to 5.0.2 (tootsuite#9134)
  Fix dimensions of preview cards, fix crash in web UI, fix warning (tootsuite#9133)
  Update i18n-tasks and change CircleCI command (tootsuite#9104)
  Reset status cache when status_stat or media_attachment updates (tootsuite#9119)
  Add progress indicators to MigrateAccountConversations (tootsuite#9101)
  Set z-index of dropdown to 9999. (tootsuite#9126)
  Include preview cards in status entity in REST API (tootsuite#9120)
  Do not remove "dead" domains in tootctl accounts cull (tootsuite#9108)
  When searching for an emoji with multiple separators, consider the full input (tootsuite#9124)
  Add locality check to ActivityPub::FetchRemoteAccountService (tootsuite#9109)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.