New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix race condition causing shallow status with only a "favourited" attribute #9272

Merged
merged 1 commit into from Nov 13, 2018

Conversation

Projects
None yet
3 participants
@ThibG
Copy link
Collaborator

ThibG commented Nov 12, 2018

Fixes #9231

@ThibG

This comment has been minimized.

Copy link
Collaborator Author

ThibG commented Nov 12, 2018

A race condition remains, where the favorite API call succeeded and the toot was deleted in the meantime. In this case, the toot is still in the redux store, but at least nothing crashes.

@ykzts

ykzts approved these changes Nov 12, 2018

@Gargron Gargron merged commit c875f19 into tootsuite:master Nov 13, 2018

11 checks passed

ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: check-i18n Your tests passed on CircleCI!
Details
ci/circleci: install Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.3 Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.4 Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.5 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.3 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.4 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.5 Your tests passed on CircleCI!
Details
ci/circleci: test-webui Your tests passed on CircleCI!
Details
codeclimate All good!
Details

Gargron added a commit that referenced this pull request Nov 23, 2018

Gomasy added a commit to Gomasy/mastodon that referenced this pull request Dec 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment