Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip deliveries to inboxes that have already been marked as unavailable #9358

merged 1 commit into from Nov 27, 2018


Copy link

commented Nov 26, 2018

While currently distribution to unavailable inboxes is stopped, already queued items still keep trying to deliver, which can mean a lot of retries. This allows to skip all that.

@Gargron Gargron added the performance label Nov 26, 2018
ThibG approved these changes Nov 27, 2018
@Gargron Gargron merged commit 1195560 into master Nov 27, 2018
11 checks passed
11 checks passed
ci/circleci: build Your tests passed on CircleCI!
ci/circleci: check-i18n Your tests passed on CircleCI!
ci/circleci: install Your tests passed on CircleCI!
ci/circleci: install-ruby2.3 Your tests passed on CircleCI!
ci/circleci: install-ruby2.4 Your tests passed on CircleCI!
ci/circleci: install-ruby2.5 Your tests passed on CircleCI!
ci/circleci: test-ruby2.3 Your tests passed on CircleCI!
ci/circleci: test-ruby2.4 Your tests passed on CircleCI!
ci/circleci: test-ruby2.5 Your tests passed on CircleCI!
ci/circleci: test-webui Your tests passed on CircleCI!
codeclimate All good!
@Gargron Gargron deleted the fix-unavailable-delivery branch Nov 27, 2018
Gomasy added a commit to Gomasy/mastodon that referenced this pull request Dec 19, 2018
…le (tootsuite#9358)
joycem137 added a commit to BeachCity/mastodon that referenced this pull request May 6, 2019
* Use backend from glitch-soc for instance-only toots

* Base frontend on privacy dropdown

* Add local_only indicator in the status action bar

* Add local_only indicator to detailed status

* Add backend support for local_only on status create
Based off ThibG implementation on glitch tootsuite#502

* Normalize translations
ran yarn build:development && i18n-tasks normalize && yarn manage:translations && i18n-tasks remove-unused

* Add local_only to admin screens

* Hide local statuses from user atom and from unlogged users

* Add local only icon to status page

* Fix issue with toggle in mobile

* Add default federation option to settings

* Fix wrong configuration fetched

* Change setting wording

* Check for empty "last_status" before sorting DM column (tootsuite#9207)

* Check for empty "last_status" before sorting

* Small touchups for codeclimate

* Update resolve_url_service.rb (tootsuite#9188)

* Increase default column width from 330px to 350px (tootsuite#9227)

* Optimize the process of following someone (tootsuite#9220)

* Eliminate extra accounts select query from FollowService

* Optimistically update follow state in web UI and hide loading bar

Fix tootsuite#6205

* Asynchronize NotifyService in FollowService

And fix failing test

* Skip Webfinger resolve routine when called from FollowService if possible

If an account is ActivityPub, then webfinger re-resolving is not necessary
when called from FollowService. Improve options of ResolveAccountService

* Fix follow limit validator reporting lower number past threshold (tootsuite#9230)

* Fix follow limit validator reporting lower number past threshold

* Avoid floating point follow limit

* Fix form validation flash message color and input borders (tootsuite#9235)

* Fix form validation flash message color and input borders

* Fix typo

* Display amount of freed disk space in tootctl media remove (tootsuite#9229)

* Display amount of freed disk space in tootctl media remove

Fix tootsuite#9213

* Fix code style issue

* Add "Show thread" link to self-replies (tootsuite#9228)

Fix tootsuite#4716

* Fix nil error regression from tootsuite#9229 in tootctl media remove (tootsuite#9239)

Fix tootsuite#9237

* Improve ActiveRecord connection in on_worker_boot (tootsuite#9238)

This is how it looks in the example in the Puma README

* Check that twitter:player is valid before using it (tootsuite#9254)

Fixes tootsuite#9251

* Fix emoji update date processing (tootsuite#9255)

* Perform deep comparison for card data when receiving new props (tootsuite#9270)

Fixes tootsuite#9226

* Fix null error introduced in tootsuite#9270 (tootsuite#9275)

* Fix race condition causing shallow status with only a "favourited" attribute (tootsuite#9272)

Fixes tootsuite#9231

* Fix "tootctl media remove" can't count the file size (tootsuite#9288)

* Fixed an issue where "tootctl media remove" can not count the file size.

* Fixed the problem pointed out by codeclimate.

* Remove intermediary arrays when creating hash maps from results (tootsuite#9291)

* Prevent multiple handlers for Delete of Actor from running (tootsuite#9292)

* Fix filter ID not being a string in REST API (tootsuite#9303)

* Update Nginx config for Nanobox apps (tootsuite#9310)

The Nanobox files have gotten out of sync, a touch, with what Masto needs for Nginx settings. This PR updates them accordingly.

* WebSub: ATOM before RSS (tootsuite#9302)

The ATOM feed contains the hub declaration for WebSub, but the RSS
version does not.
RSS/ATOM readers will typically pick whichever version comes first, and
will thus not see the WebSub feature.
I therefore suggest putting the ATOM version first, as it is more
feature-rich than its RSS counterpart is.

Clients not compatible with ATOM would not pick it anyway due to the
different type attribute.

A more complicated alternative would be to declare the WebSub feature in
the RSS version as well, using something like the following code, and
ensuring that clients subscribed to the RSS version would receive PuSH
updates just like those subscribed to the ATOM version.

<rss version="2.0" xmlns:webfeeds=""
<atom:link rel="self" type="application/rss+xml"
<atom:link rel="hub" href=""/>

* Touch account on successful response, change char shown when culled (tootsuite#9293)

Just the color is not enough change since not everyone uses colored
Touching the account makes it so that the account is not in the
threshold window in case of running again

* Ignore JSON-LD profile in mime type comparison (tootsuite#9179)

Ignore JSON-LD profile in mime type comparison

* Fix connect timeout not being enforced (tootsuite#9329)

* Fix connect timeout not being enforced

The loop was catching the timeout exception that should stop execution, so the next IP would no longer be within a timed block, which led to requests taking much longer than 10 seconds.

* Use timeout on each IP attempt, but limit to 2 attempts

* Fix code style issue

* Do not break Request#perform if no block given

* Update method stub in spec for Request

* Move timeout inside the begin/rescue block

* Use Resolv::DNS with timeout of 1 to get IP addresses

* Update Request spec to stub Resolv::DNS instead of Addrinfo

* Fix Resolve::DNS stubs in Request spec

* Bump version to 2.6.2

* add loglevel to ffmpeg in gif upload (tootsuite#9368)

* Allow hyphens in the middle of remote user names (tootsuite#9345)

Fixes tootsuite#9309

This only allows hyphens in the middle of a username, much like dots,
although I don't have a compelling reason to do so other than keeping
the changes minimal.

* Fix nil error when no DNS addresses are found for host (tootsuite#9379)

* Don't count suspended users in user count (tootsuite#9380)

Fix tootsuite#7637

* Skip deliveries to inboxes that have already been marked as unavailable (tootsuite#9358)

* Fix TLS handshake timeout not being enforced (tootsuite#9381)

Follow-up to tootsuite#9329

* Bump version to 2.6.3

* Remove npm-run-all dependency (tootsuite#9401)

Fix tootsuite#9359

* Bump version to 2.6.4

* Preload common JSON-LD contexts (tootsuite#9412)

Fixes tootsuite#9411

* Include replies to list owner and replies to list members in list statuses (tootsuite#9324)

* Bump version to 2.6.5

* Only stream local-only toots to logged-in users

* Normalize translations

* Bumps copyright year in to 2019 (tootsuite#9939)

This is so incredibly small, but assuming this is a needed change. Might want to check year in other files.

* Fix link color in high-contrast theme, add underlines (tootsuite#9949)

Improve sorting of default themes in the dropdown

* Replace unlock-alt icon with unlock (tootsuite#9952)

* Allow most kinds of characters in URL query (fixes tootsuite#8408) (tootsuite#8447)

* Allow unicode characters in URL query strings

Fixes tootsuite#8408

* Alternative approach to unicode support in urls

Adds PoC/idea to approch this problem.

* Fix authorized applications list page design (tootsuite#9969)

* Fix not showing custom emojis in share page emoji picker (tootsuite#9970)

* [UI] Fix whitespace being applied to div instead of p (tootsuite#9968)

* fix large line breaks

* fix ascii art posts

* Hide misleading “You will be sent a confirmation e-mail” hint from admin view (tootsuite#9973)

Thanks @wryk for noticing this issue.

* Fix Tombstone.delete_all ArgumentError (tootsuite#9978)

*  Only URLs extract with pre-escaped text (tootsuite#9991)

* [test] add japanese hashtag testcase

* Only URLs extract with pre-escaped text

( tootsuite#9989 )

* Fix URL linkifier grabbing full-width spaces and quotations (tootsuite#9997)

Fix tootsuite#9993
Fix tootsuite#5654

* Fix IntersectionObserverArticle not hiding some out-of-view items (tootsuite#9982)

IntersectionObserverArticle is made to save on RAM by avoiding fully rendering
items that are far out of view. However, it did not work for items spawned
outside the intersection observer.

* Fix timeline jumps (tootsuite#10001)

* Avoid two-step rendering of statuses as much as possible

Cache width shared by Video player, MediaGallery and Cards at the
ScrollableList level, pass it down through StatusList and Notifications.

* Adjust scroll when new preview cards appear

* Adjust scroll when statuses above the current scroll position are deleted

* Don't focus spiler input when disabled spoiler (tootsuite#10017)

* Move sending account Delete to anyone but the account's followers to the pull̀ queue (tootsuite#10016)

* Add support for IPv6 only MXes in Email validation (tootsuite#10009)

* Add support for IPv6 only MXes

* Fixed email validator tests

* Save IP address used for sign-up, not only sign-in (tootsuite#10026)

Fixes tootsuite#9995

* Fix color of static page links in high contrast theme (tootsuite#10028)

* Fix hashtags select styling in default and high contrast themes (tootsuite#10029)

* Fix style regressions on landing page (tootsuite#10030)

* Add tight rate-limit for API deletions (tootsuite#10042)

Deletions take a lot of resources to execute and cause a lot of
federation traffic, so it makes sense to decrease the number
someone can queue up through the API.

30 per 30 minutes

* Fix hashtag column not subscribing to stream on mount (tootsuite#10040)

Fix tootsuite#9895

* Create Redisable#redis (tootsuite#9633)

* Create Redisable

* Use #redis instead of Redis.current

* Alternative handling of private self-boosts (tootsuite#9998)

* When self-boosting, embed original toot into Announce serialization

* Process unknown self-boosts from Announce object if it is more than an URI

* Add some self-boost specs

* Only serialize private toots in self-Announces

* Filter incoming Create activities by relation to local activity (tootsuite#10005)

Reject those from accounts with no local followers, from relays
that are not enabled, which do not address local accounts and are
not replies to accounts that do have local followers

* Filter incoming Announce activities by relation to local activity (tootsuite#10041)

* Filter incoming Announce activities by relation to local activity

Reject if announcer is not followed by local accounts, and is not
from an enabled relay, and the object is not a local status

Follow-up to tootsuite#10005

* Fix tests

* Add logging for rejected ActivityPub payloads and add tests (tootsuite#10062)

* Fix Announce activities of unknown statuses not fetching those statuses (tootsuite#10065)

Regression from tootsuite#9998

* Fix relay enabling/disabling not resetting inbox availability status (tootsuite#10048)

Fix tootsuite#10033

* Change robots.txt to exclude some URLs (tootsuite#10037)

- Exclude static assets
- Exclude uploaded files
- Exclude alternate versions of the profile page
- Exclude media proxy URLs

* Change robots.txt to exclude only media proxy URLs (tootsuite#10038)

* Revert "Change robots.txt to exclude some URLs (tootsuite#10037)"

This reverts commit 80161f4.

* Let's block media_proxy

/media_proxy/ is a dynamic route used for requesting uncached media, so it's
probably bad to let crawlers use it

* misleading comment

* Improve image description user experience (tootsuite#10036)

* Add image descriptions to searchable post content.

* Allow multi-line image descriptions.

* Request image descriptions in the same query as posts when creating the search index.

(see tootsuite#10036 (comment))

* perf: run node directly when streaming (tootsuite#10032)

* Fix breaks when opening a reply tree in WebUI (tootsuite#10046)

fix tootsuite#10045

* Change conversations to always show names of other participants (tootsuite#10047)

Fix tootsuite#9190

* Change buttons on timeline preview to open the interaction dialog (tootsuite#10054)

Fix tootsuite#9922

* Change error graphic to hover-to-play (tootsuite#10055)

Fix tootsuite#6060

* Add registrations attribute to instance entity in REST API (tootsuite#10060)

Fix tootsuite#9350

* Add vapid_key to the application entity in the REST API (tootsuite#10058)

Fix tootsuite#8785

* Fix mutes, blocks, domain blocks and follow requests not paginating (tootsuite#10057)

Regression from tootsuite#9581

* Fix crash on public hashtag pages when streaming fails (tootsuite#10061)

* Bump version to 2.7.2

* Do not leak local-only toots to remote mentioned users

* Update .gitignore

* Update Beach City version to 1.4
hiyuki2578 added a commit to ProjectMyosotis/mastodon that referenced this pull request Oct 2, 2019
…le (tootsuite#9358)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
2 participants
You can’t perform that action at this time.