New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Volume sliders for videos #7429 #9366

Merged
merged 3 commits into from Nov 27, 2018

Conversation

Projects
None yet
2 participants
@sumdog
Copy link
Contributor

sumdog commented Nov 27, 2018

This is a patch to add volume support to videos and change the default volume to 50%

Questions:

  • I didn't see any selenium or web browser tests. Are there tests I need to update for this component?
  • I didn't add in Intl/messages for the volume slider since there weren't any for the seek slider. Is that alright or should I add them and to what component?

I've tested this manually on Firefox desktop, Chrome desktop, Firefox mobile and chrome mobile. It matches the behaviour of the seek slider.

Sumit Khanna added some commits Nov 27, 2018

Sumit Khanna
Sumit Khanna
Sumit Khanna
@Gargron
Copy link
Member

Gargron left a comment

💯 🎉 👌

@Gargron Gargron merged commit f978afa into tootsuite:master Nov 27, 2018

11 checks passed

ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: check-i18n Your tests passed on CircleCI!
Details
ci/circleci: install Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.3 Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.4 Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.5 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.3 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.4 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.5 Your tests passed on CircleCI!
Details
ci/circleci: test-webui Your tests passed on CircleCI!
Details
codeclimate All good!
Details

mayaeh added a commit to mayaeh/mastodon that referenced this pull request Dec 1, 2018

Volume sliders for videos tootsuite#7429 (tootsuite#9366)
* Volume sliders for videos tootsuite#7429

* Code formatting updates

* Code formatting updates
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment