New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the icon "reply" to "reply-all" when reply to other accounts #9378

Merged
merged 1 commit into from Dec 28, 2018

Conversation

Projects
None yet
5 participants
@mayaeh
Copy link
Collaborator

mayaeh commented Nov 27, 2018

After #9228 , the reply icon is unified to "reply" and the "Show thread" message is displayed in the self reply.

I agree with the display of the "Show thread" message.

However, after #9228, I think that it has become difficult to distinguish whether reply to other people is reply or call.

So I changed the icon to “reply-all” when replies to others.

How about this?

before:
2018-11-28 1 14 00

after:
2018-11-27 16 20 21

@ThibG

ThibG approved these changes Nov 27, 2018

Copy link
Collaborator

ThibG left a comment

I agree, this conveys more information than the thread link thingy.

@Gargron Gargron merged commit c169382 into tootsuite:master Dec 28, 2018

11 checks passed

ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: check-i18n Your tests passed on CircleCI!
Details
ci/circleci: install Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.3 Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.4 Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.5 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.3 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.4 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.5 Your tests passed on CircleCI!
Details
ci/circleci: test-webui Your tests passed on CircleCI!
Details
codeclimate All good!
Details

@mayaeh mayaeh deleted the mayaeh:reply-all_other branch Dec 30, 2018

@rixx

This comment has been minimized.

Copy link

rixx commented Jan 20, 2019

Shouldn't the icon still be "reply" if I'll end up replying to only one person, as is the case when that person mentioned only me?

@joyeusenoelle

This comment has been minimized.

Copy link
Contributor

joyeusenoelle commented Jan 22, 2019

No; the doubled arrow represents more than one person in the conversation, not more than one recipient.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment