New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip mailer job retries when a record no longer exists #9590

Merged
merged 1 commit into from Dec 21, 2018

Conversation

Projects
None yet
3 participants
@Gargron
Copy link
Member

Gargron commented Dec 20, 2018

Fix #8666

@Gargron Gargron added the bug label Dec 20, 2018

@ThibG

This comment has been minimized.

Copy link
Collaborator

ThibG commented Dec 20, 2018

I'm concerned this may be too broad? But on the other hand, I can't see any occurrence where a job would fail with this error then work on a next attempt, hm…

@Gargron

This comment has been minimized.

Copy link
Member Author

Gargron commented Dec 20, 2018

@ThibG This is only within the ActiveMailer job, not any other Sidekiq workers.

@ykzts

ykzts approved these changes Dec 20, 2018

@Gargron Gargron merged commit 240c122 into master Dec 21, 2018

11 checks passed

ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: check-i18n Your tests passed on CircleCI!
Details
ci/circleci: install Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.3 Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.4 Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.5 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.3 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.4 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.5 Your tests passed on CircleCI!
Details
ci/circleci: test-webui Your tests passed on CircleCI!
Details
codeclimate All good!
Details

@Gargron Gargron deleted the fix-mailer-deserialization-retries branch Dec 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment