New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve admin UI for domain (block) management #9645

Merged
merged 1 commit into from Jan 8, 2019

Conversation

Projects
None yet
5 participants
@Gargron
Copy link
Member

Gargron commented Dec 28, 2018

  • Retire legacy "resubscribe" function from known instances page
  • Unite "known instances" and "domain blocks" into "federation"
  • Dashboard for any known domain

image

image

image

@Gargron Gargron force-pushed the feature-admin-instances branch 5 times, most recently from e11c61d to 11a9aca Jan 2, 2019

@jeroenpraat

This comment has been minimized.

Copy link

jeroenpraat commented Jan 5, 2019

Good idea to combine those two. I also like the UI.

I advise to change the title 'Federation'. This title doesn't explain enough what to find here. Maybe 'Other instances' or 'Other domains' is better.

@CrazyJake88

This comment has been minimized.

Copy link

CrazyJake88 commented Jan 5, 2019

The date a domain was limited should be included next to it. We also need a text field to add a note like when moderating individual reports as to why a domain was limited.

@Gargron Gargron force-pushed the feature-admin-instances branch from 11a9aca to 89ae43d Jan 5, 2019

@Gargron Gargron force-pushed the feature-admin-instances branch from 89ae43d to 8f6d6ca Jan 5, 2019

@nightpool

This comment has been minimized.

Copy link
Collaborator

nightpool commented Jan 6, 2019

Im not sure im a 100% convinced that conflating federation and Known Accounts is a good idea? Unless the label is misleading and it actually lists all accounts that follow or are being followed by local accounts

@nightpool

This comment has been minimized.

Copy link
Collaborator

nightpool commented Jan 6, 2019

Maybe we should replace silenced with "Hide" and suspend with "Ban", to be more intuitive?

EDIT: eh, maybe not

@ThibG

ThibG approved these changes Jan 8, 2019

@Gargron Gargron merged commit 1c6588a into master Jan 8, 2019

11 checks passed

ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: check-i18n Your tests passed on CircleCI!
Details
ci/circleci: install Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.4 Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.5 Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.6 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.4 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.5 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.6 Your tests passed on CircleCI!
Details
ci/circleci: test-webui Your tests passed on CircleCI!
Details
codeclimate All good!
Details

@Gargron Gargron deleted the feature-admin-instances branch Jan 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment