New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add attachment list fallback to public pages #9780

Merged
merged 2 commits into from Jan 13, 2019

Conversation

Projects
None yet
3 participants
@ThibG
Copy link
Collaborator

ThibG commented Jan 10, 2019

Fixes #6714

I'm not too familiar with HAML, so I'm not sure if the fallback-as-a-block pattern makes a lot of sense.
Also, the code for rendering the list should probably be moved into another fragment or a helper.

Looks like this when the JS part hasn't loaded yet / if it doesn't load:
screenshot_2019-01-10 thib thib mastodev sitedethib com

@Gargron

This comment has been minimized.

Copy link
Member

Gargron commented Jan 11, 2019

Something is not right in the screenshot. Spacing to the icon as well as the color of the icon.

@Gargron

This comment has been minimized.

Copy link
Member

Gargron commented Jan 11, 2019

I think it should be possible to reuse the CSS of the AttachmentList component instead of redefining a copy.

@ThibG ThibG force-pushed the ThibG:features/public-nojs-fallback branch 3 times, most recently from 9d72364 to e68fcbd Jan 11, 2019

@ThibG ThibG force-pushed the ThibG:features/public-nojs-fallback branch from e68fcbd to 2c4148b Jan 11, 2019

@ThibG

This comment has been minimized.

Copy link
Collaborator Author

ThibG commented Jan 11, 2019

Oops, updated it, it looks like this now:
screenshot_2019-01-11 thib thib mastodev sitedethib com

@ykzts

ykzts approved these changes Jan 12, 2019

@ThibG ThibG force-pushed the ThibG:features/public-nojs-fallback branch from 8ff549b to 23c4729 Jan 12, 2019

@ThibG ThibG force-pushed the ThibG:features/public-nojs-fallback branch from 23c4729 to 34b0cab Jan 12, 2019

@Gargron Gargron merged commit 4fb94c7 into tootsuite:master Jan 13, 2019

11 checks passed

ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: check-i18n Your tests passed on CircleCI!
Details
ci/circleci: install Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.4 Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.5 Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.6 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.4 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.5 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.6 Your tests passed on CircleCI!
Details
ci/circleci: test-webui Your tests passed on CircleCI!
Details
codeclimate All good!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment