Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WebP support #9879

Merged
merged 2 commits into from Feb 2, 2019

Conversation

@acid-chicken
Copy link
Contributor

commented Jan 20, 2019

Resolves #8165

@mayaeh

This comment has been minimized.

Copy link
Collaborator

commented Jan 20, 2019

I think that we can't see this file type in Safari and Firefox which are currently released.

@JanJastrow

This comment has been minimized.

Copy link

commented Jan 28, 2019

@mayaeh the coming version of Firefox 56 will likely include WebP support.

@Alch-Emi

This comment has been minimized.

Copy link

commented Feb 1, 2019

Update to this: Firefox 65 is now out and does support WebP. This includes Firefox for Android and Desktop, though not iOS.

See https://www.mozilla.org/en-US/firefox/65.0/releasenotes/

@@ -25,10 +25,10 @@ class MediaAttachment < ApplicationRecord

enum type: [:image, :gifv, :video, :unknown]

IMAGE_FILE_EXTENSIONS = ['.jpg', '.jpeg', '.png', '.gif'].freeze
IMAGE_FILE_EXTENSIONS = ['.jpg', '.jpeg', '.png', '.gif', '.webp'].freeze

This comment has been minimized.

Copy link
@Gargron

Gargron Feb 1, 2019

Member

How about this: Keep the support but remove the changes to the tooltip. Then it's future-proof without encouraging users to upload images that still aren't supported by Safari/iOS

This comment has been minimized.

Copy link
@acid-chicken

acid-chicken Feb 2, 2019

Author Contributor

@Gargron Thank you for the review! I've removed the changes at 993e3e0. Is this alright with you?

@Gargron

Gargron approved these changes Feb 2, 2019

@Gargron Gargron merged commit 5092d17 into tootsuite:master Feb 2, 2019

11 checks passed

ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: check-i18n Your tests passed on CircleCI!
Details
ci/circleci: install Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.4 Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.5 Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.6 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.4 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.5 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.6 Your tests passed on CircleCI!
Details
ci/circleci: test-webui Your tests passed on CircleCI!
Details
codeclimate All good!
Details

masanbol added a commit to masanbol/snoutsonline that referenced this pull request Feb 3, 2019

benharri added a commit to tildeverse/mastodon that referenced this pull request Mar 5, 2019

Add WebP support (tootsuite#9879)
* Add WebP support

* Remove the changes to the tooltip

refs: tootsuite#9879 (review)

@acid-chicken acid-chicken deleted the SweakNetwork:webp branch Jun 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.