New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix scheduled toot with media immediately creating a toot #9894

Merged
merged 2 commits into from Jan 21, 2019

Conversation

Projects
None yet
4 participants
@ThibG
Copy link
Collaborator

ThibG commented Jan 21, 2019

No description provided.

ThibG added some commits Jan 21, 2019

Prevent status used for validation from being persisted to the database
Fixes #9893

Thanks to tateisu for the help investigating this.

@ThibG ThibG changed the title [WiP] Fix scheduled toot with media immediately creating a toot Fix scheduled toot with media immediately creating a toot Jan 21, 2019

@tateisu

This comment has been minimized.

Copy link
Contributor

tateisu commented Jan 21, 2019

I tried this PR on my test server, it works perfect.
also it allows my app to reuse media attachment when "delete and redraft" scheduled status. thx!

@mayaeh

This comment has been minimized.

Copy link
Collaborator

mayaeh commented Jan 21, 2019

There seems to be no problem in the range I tried.
I think that this problem was fixed.
Thank you !

@Gargron Gargron merged commit 061feb6 into tootsuite:master Jan 21, 2019

11 checks passed

ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: check-i18n Your tests passed on CircleCI!
Details
ci/circleci: install Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.4 Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.5 Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.6 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.4 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.5 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.6 Your tests passed on CircleCI!
Details
ci/circleci: test-webui Your tests passed on CircleCI!
Details
codeclimate All good!
Details

kedamaDQ added a commit to kedamaDQ/mastodon that referenced this pull request Jan 25, 2019

Fix scheduled toot with media immediately creating a toot (tootsuite#…
…9894)

* Add test for not persisting status when attaching media to scheduled toot

* Prevent status used for validation from being persisted to the database

Fixes tootsuite#9893

Thanks to tateisu for the help investigating this.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment