Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make unlisted/unlocked icon more distinguishable #9952

Merged
merged 1 commit into from Jan 31, 2019

Conversation

Projects
None yet
2 participants
@clarfon
Copy link
Contributor

clarfon commented Jan 31, 2019

Currently, the unlisted privacy setting, among other things in the UI, is displayed using the fa-unlock-alt icon. Unfortunately, in most cases, it's incredibly difficult to see the difference between these two icons, which can make distinguishing between whether your post is set to unlisted or private difficult. This change replaces all uses of the fa-unlock-alt icon with fa-unlock (in both the privacy and block UIs), so that it can be easier to tell the difference.

Here's how it looks before the change:

Older version

And here's how it looks after:

Newer version

@Gargron Gargron merged commit 6513f6c into tootsuite:master Jan 31, 2019

11 checks passed

ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: check-i18n Your tests passed on CircleCI!
Details
ci/circleci: install Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.4 Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.5 Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.6 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.4 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.5 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.6 Your tests passed on CircleCI!
Details
ci/circleci: test-webui Your tests passed on CircleCI!
Details
codeclimate All good!
Details

masanbol added a commit to masanbol/snoutsonline that referenced this pull request Feb 3, 2019

Gargron added a commit that referenced this pull request Feb 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.