Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Ruby to 2.6.1 #9956

Merged
merged 1 commit into from Feb 20, 2019

Conversation

Projects
None yet
4 participants
@zunda
Copy link
Collaborator

zunda commented Jan 31, 2019

I'm not sure if the fixed bug affects us but just in case.

Net::Protocol::BufferedIO#write raises NoMethodError when sending large multi-byte string has been fixed.

@ykzts

ykzts approved these changes Jan 31, 2019

@angristan

This comment has been minimized.

Copy link
Contributor

angristan commented Feb 17, 2019

LGTM. No issue so far on 2.6.1 for me

@Gargron

This comment has been minimized.

Copy link
Member

Gargron commented Feb 17, 2019

People complain whenever .ruby-version is updated and we just updated it in 2.7.0, so I just think this is too soon. I don't believe the mentioned bug affects our code.

@angristan

This comment has been minimized.

Copy link
Contributor

angristan commented Feb 17, 2019

Ok 👌

@angristan

This comment has been minimized.

Copy link
Contributor

angristan commented Feb 20, 2019

It turns out elasticsearch-rails has a bug in 2.6.1: elastic/elasticsearch-rails#866

Another PR has been made to update the Ruby version: #10083

@Gargron Gargron merged commit aa6a4b7 into tootsuite:master Feb 20, 2019

11 checks passed

ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: check-i18n Your tests passed on CircleCI!
Details
ci/circleci: install Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.4 Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.5 Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.6 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.4 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.5 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.6 Your tests passed on CircleCI!
Details
ci/circleci: test-webui Your tests passed on CircleCI!
Details
codeclimate All good!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.