Minor changes to help with first time indexing #30

wants to merge 9 commits into


None yet
3 participants

I had trouble when I was first indexing. It would seem to complete without saying anything. So, I added a "-v" option to allow some verbosity to be able to tell what the heck was going on.

Figured out that the issue was that ACCEPTED_FORMATS used to be defined in shiva/config/project.py but that got removed in aa76a0a however the indexer.py still examines it and would never match in is_track() so nothing would be indexed. Decided to warn the user to update the configuration similar to the warning just above for MEDIA_DIRS.

I can clean/change either of these if required.

👍 for versbosity.

If it can also summarize indexing results at end of running indexer - would help.

Could you please move this inside the main in line 189?

Take a look how --lastfm and --nometadata are handled, check for the parameter and pass it to the Indexer object, in order to avoid global vars.

if self.verbose:


tooxie commented Mar 23, 2013

👍 to the --verbose flag.

@nishantmodak I like your idea of the report at the end: which information would you include? I'm thinking of number of files indexed, maybe number of artists, "orphan" tracks (without known artist). What else?

@tooxie Yes. That sounds like a good summary to begin with.

@dbrgn dbrgn added a commit to dbrgn/shiva-server that referenced this pull request Mar 31, 2013

@dbrgn dbrgn Replaced ACCEPTED_FORMATS with VALID_FILE_EXTENSIONS in indexer (refs #… 41499f3

tooxie closed this Apr 1, 2013



tooxie commented Apr 2, 2013

I merged the oggsupport branch into master, github closed this PR automatically. Could you please update your copy with the latest master and re-issue this PR? Thanks! 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment