Errno::ECHILD thrown from Process.waitpid, some Process methods #732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ) | ||
| space.globals.set(space, "$?", w_status) | ||
| return space.newint(pid) | ||
| except OSError as ex: |
There was a problem hiding this comment.
Only the minim amount of code should be inside of the try block.
|
@alex feel free to merge if Travis says it's green and you haven't got further comments. |
| try: | ||
| name = _errno_for_oserror_map[exc.errno] | ||
| except KeyError: | ||
| raise NotImplementedError("no such errno: %s" % exc.errno) |
There was a problem hiding this comment.
This should probably just raise a normal SystemCallError if we don't know the specific sucblass.
There was a problem hiding this comment.
To be honest this whole function should be merged with the other error_for_oserror function.
| try: | ||
| name = _errno_for_oserror_map[exc.errno] | ||
| type = space.find_const(space.find_const(callee, "Errno"), name) | ||
| except KeyError: |
There was a problem hiding this comment.
Only the name = ... line should be in the try/except block, you can use the try/except/else form to acheive that.
alex
added a commit
that referenced
this pull request
May 27, 2013
Errno::ECHILD thrown from Process.waitpid, some Process methods
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.