Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a typo and update README with nullable and some new examples #82

Merged
merged 3 commits into from
May 14, 2020
Merged

Fix a typo and update README with nullable and some new examples #82

merged 3 commits into from
May 14, 2020

Conversation

ChristopheB
Copy link
Contributor

@ChristopheB ChristopheB commented May 13, 2020

Here is the README update about nullable #80. I added just a few words about that, but nothing about a possible breaking change.

I also updated the examples. I tried hard to find a simple real world example while writing the tests for nullable the other day, and I though I would share that. Let me know if that makes sense.

And finally there is a fix for a typo I introduced in the previous PR #81 .

@ChristopheB
Copy link
Contributor Author

ChristopheB commented May 13, 2020

This text might help:

Version 2.x brings support for nullable columns. The results may now be different than on version 1.x when a column is null on a relationship, so we bumped the version to 2.x, as this might be a breaking change for you.

Not sure where to put it though.

@topclaudy topclaudy merged commit d92ef0d into topclaudy:master May 14, 2020
@topclaudy
Copy link
Owner

@ChristopheB Your contribution is really appreciated. 2.0.0 is released!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants