Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Topdoc support #1

Closed
kristoferjoseph opened this issue Nov 8, 2013 · 4 comments
Closed

Add Topdoc support #1

kristoferjoseph opened this issue Nov 8, 2013 · 4 comments

Comments

@kristoferjoseph
Copy link
Member

Add topdoc generation to Resin

@SlexAxton
Copy link
Contributor

Is this closed because you can just run topdoc against normal resin stuff, or because it's not gonna happen?

@kristoferjoseph
Copy link
Member Author

Sorry, I should have added an explanation. I had intended to add Topdoc to resin and have a flag to enable it. I decided to punt on this feature because you can run Topdoc on the output and I wasn't sure how useful having it all in one place was. Very open to adding this in, just wasn't sure if people needed it.

Thoughts?

@SlexAxton
Copy link
Contributor

I think as long as it's possible to do on output (e.g. the comments aren't all removed in the resin step) - then there's no convincing need to add it here.

@kristoferjoseph
Copy link
Member Author

Right. Comments are not removed. Passing the output through Topdoc is
completely possible. This is how we use it in the main topcoat build.

On Wednesday, May 21, 2014, Alex Sexton notifications@github.com wrote:

I think as long as it's possible to do on output (e.g. the comments aren't
all removed in the resin step) - then there's no convincing need to add it
here.


Reply to this email directly or view it on GitHubhttps://github.com//issues/1#issuecomment-43815897
.

Kristofer

GarthDB pushed a commit that referenced this issue Sep 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants