Update all components to desktop parity #375

Closed
kristoferjoseph opened this Issue Aug 27, 2013 · 12 comments

Comments

Projects
None yet
5 participants
@kristoferjoseph
Member

kristoferjoseph commented Aug 27, 2013

Desktop parity will be achieved!

best_star_trek

Steps to desktop parity are:

Components to review

@kristoferjoseph

This comment has been minimized.

Show comment
Hide comment
@kristoferjoseph

kristoferjoseph Aug 27, 2013

Member

@larz0 once this issue is closed you should give a once through.
I will add the links to the pages for you in the comments of this bug.
Please file issues for anything we miss after that.
Should be much more manageable for you holmes.

pray_kitteh

Member

kristoferjoseph commented Aug 27, 2013

@larz0 once this issue is closed you should give a once through.
I will add the links to the pages for you in the comments of this bug.
Please file issues for anything we miss after that.
Should be much more manageable for you holmes.

pray_kitteh

@piatra

This comment has been minimized.

Show comment
Hide comment
@piatra

piatra Aug 27, 2013

Contributor

My updates are inline. Review comment or modify if needed
Almost all of the updates depend on a version bump of topcoat-theme. Tests will fail until new version is published on npm. Use npm link to test locally.

Contributor

piatra commented Aug 27, 2013

My updates are inline. Review comment or modify if needed
Almost all of the updates depend on a version bump of topcoat-theme. Tests will fail until new version is published on npm. Use npm link to test locally.

@kristoferjoseph

This comment has been minimized.

Show comment
Hide comment
@kristoferjoseph

kristoferjoseph Aug 27, 2013

Member

@larz0 Yo, is there a comp for a desktop search input? Is this one good?
Search input

Otherwise we can pull the desktop version until someone adds it to the psd........... loading NaN%

Member

kristoferjoseph commented Aug 27, 2013

@larz0 Yo, is there a comp for a desktop search input? Is this one good?
Search input

Otherwise we can pull the desktop version until someone adds it to the psd........... loading NaN%

@larz0

This comment has been minimized.

Show comment
Hide comment
@larz0

larz0 Aug 28, 2013

Contributor

@kristoferjoseph thanks for the heads up. Hoping to check it out on Friday.

Contributor

larz0 commented Aug 28, 2013

@kristoferjoseph thanks for the heads up. Hoping to check it out on Friday.

@kristoferjoseph

This comment has been minimized.

Show comment
Hide comment
@kristoferjoseph

kristoferjoseph Aug 28, 2013

Member

@larz0 Anything for you my ninja.
If you feel like banging out some sizing scales it would make this stuff more fun to build.

Member

kristoferjoseph commented Aug 28, 2013

@larz0 Anything for you my ninja.
If you feel like banging out some sizing scales it would make this stuff more fun to build.

@nnnnic

This comment has been minimized.

Show comment
Hide comment
@nnnnic

nnnnic Aug 28, 2013

Collaborator

Fridae is the Githubz Dae.

Collaborator

nnnnic commented Aug 28, 2013

Fridae is the Githubz Dae.

@kristoferjoseph

This comment has been minimized.

Show comment
Hide comment
@GarthDB

This comment has been minimized.

Show comment
Hide comment
@GarthDB

GarthDB Aug 29, 2013

Member

Making progress

dance

Member

GarthDB commented Aug 29, 2013

Making progress

dance

@larz0

This comment has been minimized.

Show comment
Hide comment
@larz0

larz0 Aug 29, 2013

Contributor

Hahahaha

Contributor

larz0 commented Aug 29, 2013

Hahahaha

@kristoferjoseph

This comment has been minimized.

Show comment
Hide comment
@kristoferjoseph

kristoferjoseph Aug 29, 2013

Member

@larz & @nnnnic Here are the links to the components for design review:
Button
Button Bar
Checkbox
Icon Button
List *Mobile only since there was no desktop design
Navigation Bar *Mobile only. Will need designs for desktop header
Radio Button
Search Input
Text Input
Text Area *Desktop version was not in psd so we took our best shot
bungee_jumper_hesitates

Member

kristoferjoseph commented Aug 29, 2013

@larz & @nnnnic Here are the links to the components for design review:
Button
Button Bar
Checkbox
Icon Button
List *Mobile only since there was no desktop design
Navigation Bar *Mobile only. Will need designs for desktop header
Radio Button
Search Input
Text Input
Text Area *Desktop version was not in psd so we took our best shot
bungee_jumper_hesitates

@nnnnic

This comment has been minimized.

Show comment
Hide comment
@nnnnic

nnnnic Aug 29, 2013

Collaborator

Dope thanks!

Hollering atcha soon.

On Aug 29, 2013, at 8:48 AM, "Kristofer Joseph" <notifications@github.commailto:notifications@github.com> wrote:

@larzhttps://github.com/larz & @nnnnichttps://github.com/nnnnic Here are the links to the components for design review:
Buttonhttp://topcoat.io/button
Checkboxhttp://topcoat.io/checkbox
Icon Buttonhttp://topcoat.io/icon-button
Listhttp://topcoat.io/list *Mobile only since there was no desktop design
Navigation Barhttp://topcoat.io/navigation-bar *Mobile only. Will need designs for desktop header
Radio Buttonhttp://topcoat.io/radio-button
Search Inputhttp://topcoat.io/search-input
Text Inputhttp://topcoat.io/text-input *Needs valid state added. Input turns green once Invalide Red state is satisfied.
Text Areahttp://topcoat.io/textarea *Desktop version was not in psd so we took our best shot


Reply to this email directly or view it on GitHubhttps://github.com/topcoat/topcoat/issues/375#issuecomment-23499802.

Collaborator

nnnnic commented Aug 29, 2013

Dope thanks!

Hollering atcha soon.

On Aug 29, 2013, at 8:48 AM, "Kristofer Joseph" <notifications@github.commailto:notifications@github.com> wrote:

@larzhttps://github.com/larz & @nnnnichttps://github.com/nnnnic Here are the links to the components for design review:
Buttonhttp://topcoat.io/button
Checkboxhttp://topcoat.io/checkbox
Icon Buttonhttp://topcoat.io/icon-button
Listhttp://topcoat.io/list *Mobile only since there was no desktop design
Navigation Barhttp://topcoat.io/navigation-bar *Mobile only. Will need designs for desktop header
Radio Buttonhttp://topcoat.io/radio-button
Search Inputhttp://topcoat.io/search-input
Text Inputhttp://topcoat.io/text-input *Needs valid state added. Input turns green once Invalide Red state is satisfied.
Text Areahttp://topcoat.io/textarea *Desktop version was not in psd so we took our best shot


Reply to this email directly or view it on GitHubhttps://github.com/topcoat/topcoat/issues/375#issuecomment-23499802.

@larz0

This comment has been minimized.

Show comment
Hide comment
@larz0

larz0 Aug 30, 2013

Contributor

Thanks @kristoferjoseph. Will review one I'm done with other tasks~

Contributor

larz0 commented Aug 30, 2013

Thanks @kristoferjoseph. Will review one I'm done with other tasks~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment