This repository was archived by the owner on Mar 4, 2025. It is now read-only.
SUP-1050, Hitting back button after any my-dashboard link breaks my-dashboard@ #137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ashboard It was happening because getHandle method is not being called on back button which was happening because of page being marked as cached. For now, workaround it by marking the page non cached because down v2 of dashboard will be a separate app which would not be depdendent on tc-site.
thabofletcher
added a commit
that referenced
this pull request
Jul 24, 2015
…ckbutton SUP-1050, Hitting back button after any my-dashboard link breaks my-dashboard@
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was happening because getHandle method is not being called on back button which was happening because of page being marked as cached. For now, workaround it by marking the page non cached because down v2 of dashboard will be a separate app which would not be dependent on tc-site.
@thabofletcher @parthshah fyi