This repository was archived by the owner on Mar 4, 2025. It is now read-only.
Feature/submission bughunt fixes #858
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
July 7, 2016 12:18
… image upload -- Fixed with catch that it still allows any file named with zip extension.
…ads to overlap with help text -- Fixed, with catch been that 'or' keyword is not removed in case of file type does not match the required types because we don't get the event from filestack for this case.
…ads to overlap with help text -- Fixed
-- Changed copies. -- Implemented all points except >>Also, please make sure this page can't somehow revert to an error state, which happened when the submission failed.<<
-- Fixed all sub tasks except >> On the right-hand side, move comma as so: "declaration.txt,"
| // set mimeTypes | ||
| if (scope.fieldId.indexOf('ZIP') > -1) { | ||
| scope.extensions = '.zip' | ||
| scope.mimeTypes = 'application/zip' |
Contributor
There was a problem hiding this comment.
@vikasrohit we've had lots of problems with mimetypes with our current implementation. So I wanted to switch to extensions only.
Contributor
Author
There was a problem hiding this comment.
Okay, so should I revert the changes?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@parthshah @fnisen