From 8c9288add025a44d5e96f962efaf2ad2d8863786 Mon Sep 17 00:00:00 2001 From: Nitin Jaiswal Date: Sun, 20 May 2018 01:52:58 +0530 Subject: [PATCH 1/2] Added missing import for react, without which page breaks - To see this page MAINTENANCE_MODE should be set to true in src/config/constants.js near line 321 --- src/components/Maintenance/Maintenance.jsx | 1 + 1 file changed, 1 insertion(+) diff --git a/src/components/Maintenance/Maintenance.jsx b/src/components/Maintenance/Maintenance.jsx index ebe1c1aef..f03898e81 100644 --- a/src/components/Maintenance/Maintenance.jsx +++ b/src/components/Maintenance/Maintenance.jsx @@ -1,3 +1,4 @@ +import React from 'react' import './Maintenance.scss' const Maintenance = () => { From 42a0a3be7a5e351c4037418a54d2df7da97f4f66 Mon Sep 17 00:00:00 2001 From: Nitin Jaiswal Date: Sun, 20 May 2018 02:10:20 +0530 Subject: [PATCH 2/2] Unlike src/routes/notifications/routes.jsx in this file a Switch is exported instead of just routes, which is capturing any unmatched route and making any route below this unaccessible (e.g. /404 or /error). Also, comma after jsx comments is required because jsx is not contained inside any function --- src/routes/settings/routes.jsx | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/src/routes/settings/routes.jsx b/src/routes/settings/routes.jsx index 95b3efe56..900456a6e 100644 --- a/src/routes/settings/routes.jsx +++ b/src/routes/settings/routes.jsx @@ -2,7 +2,7 @@ * Settings routes */ import React from 'react' -import { Route, Switch } from 'react-router-dom' +import { Route } from 'react-router-dom' import { renderApp } from '../../components/App/App' import TopBarContainer from '../../components/TopBar/TopBarContainer' import NotificationsToolBar from '../notifications/components/NotificationsToolBar' @@ -12,9 +12,7 @@ import NotificationSettingsContainer from './routes/notifications/containers/Not // import ProfileSettingsContainer from './routes/profile/containers/ProfileSettingsContainer' export default ( - - {/*, )} />*/} - {/*, )} />*/} - , )} /> - + {/*, )} />*/}, + {/*, )} />*/}, + , )} /> )