From 925b9c9fe0f78ee472c3691c26e87f1a643bcf1f Mon Sep 17 00:00:00 2001 From: Vikas Agarwal Date: Fri, 14 Sep 2018 14:06:38 +0530 Subject: [PATCH 1/2] Fixed sending segment events. RegEx was not matching the pathname. --- src/routes.jsx | 22 +++++++++++++++------- 1 file changed, 15 insertions(+), 7 deletions(-) diff --git a/src/routes.jsx b/src/routes.jsx index 6e47d949f..b94b9299c 100644 --- a/src/routes.jsx +++ b/src/routes.jsx @@ -25,21 +25,29 @@ const onRouteChange = (pathname) => { TCEmitter.emit(EVENT_ROUTE_CHANGE, pathname) if (window.analytics) { - if (/^projects\/$/.test(pathname)) { + if (/^\/projects\/$/.test(pathname)) { window.analytics.page('Project Listings') - } else if (/^projects\/\d+\/?$/.test(pathname)) { + } else if (/^\/projects\/\d+\/?$/.test(pathname)) { window.analytics.page('Project Dashboard') - } else if (/^projects\/\d+\/discussions\/?$/.test(pathname)) { + } else if (/^\/projects\/\d+\/discussions\/?$/.test(pathname)) { window.analytics.page('Project Discussions') - } else if (/^projects\/\d+\/specification\/?$/.test(pathname)) { + } else if (/^\/projects\/\d+\/specification\/?$/.test(pathname)) { window.analytics.page('Project Specification') + } else if (/^\/projects\/\d+\/scope\/?$/.test(pathname)) { + window.analytics.page('Project Scope') + } else if (/^\/projects\/\d+\/plan\/?$/.test(pathname)) { + window.analytics.page('Project Plan') + } else if (/^\/settings\/notifications\/?$/.test(pathname)) { + window.analytics.page('Notification Settings') + } else if (/^\/notifications\/?$/.test(pathname)) { + window.analytics.page('Notification Listings') } else if (/^\/$/.test(pathname)) { window.analytics.page('Connect Home') - } else if (/^new-project\/$/.test(pathname)) { + } else if (/^\/new-project\/$/.test(pathname)) { window.analytics.page('New Project : Select Product') - } else if (/^new-project\/incomplete$/.test(pathname)) { + } else if (/^\/new-project\/incomplete$/.test(pathname)) { window.analytics.page('New Project : Incomplete Project') - } else if (/^new-project\/[a-zA-Z0-9_]+$/.test(pathname)) { + } else if (/^\/new-project\/[a-zA-Z0-9_]+$/.test(pathname)) { window.analytics.page('New Project : Project Details') } } From a21bb69810623dd1469a0211ab02c7f8e8cb1d89 Mon Sep 17 00:00:00 2001 From: Vikas Agarwal Date: Fri, 14 Sep 2018 14:40:56 +0530 Subject: [PATCH 2/2] Slight corrections for New project related page events --- src/routes.jsx | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/routes.jsx b/src/routes.jsx index b94b9299c..a12afb206 100644 --- a/src/routes.jsx +++ b/src/routes.jsx @@ -44,11 +44,11 @@ const onRouteChange = (pathname) => { } else if (/^\/$/.test(pathname)) { window.analytics.page('Connect Home') } else if (/^\/new-project\/$/.test(pathname)) { - window.analytics.page('New Project : Select Product') + window.analytics.page('New Project : Select Project Category') } else if (/^\/new-project\/incomplete$/.test(pathname)) { window.analytics.page('New Project : Incomplete Project') - } else if (/^\/new-project\/[a-zA-Z0-9_]+$/.test(pathname)) { - window.analytics.page('New Project : Project Details') + } else if (/^\/new-project\/[a-zA-Z0-9_-]+$/.test(pathname)) { + window.analytics.page('New Project : Project Template/Details') } } }