From 4540c5bfe6fa45306efc3c95fd2d7345c57817f8 Mon Sep 17 00:00:00 2001 From: Vikas Agarwal Date: Fri, 14 Dec 2018 14:36:05 +0530 Subject: [PATCH] Github issue#2718, Unable to load messages for customers - Proper fix after identifying the root cause. Previous fix is also good to have for future unhandled situations. RCA: the issue is reproducible when there is at least one active phase in the project and there is a notification for timeline adjustment for one of the phases. Error appears when app tries to auto expand the active phase cards on the dashboard. And reason for the issue not being reproducible as Admin or Manager role is that we don't auto expand the phase card for any non customer user. --- src/projects/detail/components/timeline/Timeline/Timeline.jsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/projects/detail/components/timeline/Timeline/Timeline.jsx b/src/projects/detail/components/timeline/Timeline/Timeline.jsx index 0a1c5bd2e..cccc18625 100644 --- a/src/projects/detail/components/timeline/Timeline/Timeline.jsx +++ b/src/projects/detail/components/timeline/Timeline/Timeline.jsx @@ -111,7 +111,7 @@ class Timeline extends React.Component { key="notifications-reader" id={`phase-${phaseId}-timeline-${timeline.id}`} criteria={[ - { eventType: EVENT_TYPE.PROJECT_PLAN.TIMELINE_ADJUSTED, contents: { timeline: { id: timeline.id } } }, + { eventType: EVENT_TYPE.PROJECT_PLAN.TIMELINE_ADJUSTED, contents: { updatedTimeline: { id: timeline.id } } }, { eventType: EVENT_TYPE.PROJECT_PLAN.MILESTONE_ACTIVATED, contents: { timeline: { id: timeline.id } } }, { eventType: EVENT_TYPE.PROJECT_PLAN.MILESTONE_COMPLETED, contents: { timeline: { id: timeline.id } } }, { eventType: EVENT_TYPE.PROJECT_PLAN.WAITING_FOR_CUSTOMER_INPUT, contents: { timeline: { id: timeline.id } } },