From 7fca6bb10ee9086176e40cd9e40ed43e35c626c1 Mon Sep 17 00:00:00 2001
From: Maksym Mykhailenko <maxceem@gmail.com>
Date: Thu, 7 Mar 2019 19:33:04 +0800
Subject: [PATCH 1/4] fix #2883 - Cannot choose particular members when
 uploading an attachement

---
 .../FileList/AddFilePermissions.jsx           | 23 +++++++++++--------
 .../UserAutoComplete/UserAutoComplete.jsx     |  5 +++-
 2 files changed, 18 insertions(+), 10 deletions(-)

diff --git a/src/components/FileList/AddFilePermissions.jsx b/src/components/FileList/AddFilePermissions.jsx
index 904e7adc6..0a44b3433 100644
--- a/src/components/FileList/AddFilePermissions.jsx
+++ b/src/components/FileList/AddFilePermissions.jsx
@@ -15,7 +15,7 @@ const AddFilePermission = ({ onCancel, onSubmit, onChange, selectedUsers, projec
     const projectMembersByHandle = mapKeys(projectMembers, value => value.handle)
     return handles.filter(handle => handle).map(h => get(projectMembersByHandle[h], 'userId'))
   }
-  
+
   return (
     <Modal
       isOpen
@@ -43,15 +43,20 @@ const AddFilePermission = ({ onCancel, onSubmit, onChange, selectedUsers, projec
             >All project members</button>
           </div>
         </div>
-        
+
         {/* Share with specific people */}
         <div className="input-container">
           <div className="hint">OR ONLY SPECIFIC PEOPLE</div>
 
-          <UserAutoComplete projectMembers={projectMembers} selectedUsers={selectedUsers} onUpdate={onChange} loggedInUser={loggedInUser} />
+          <UserAutoComplete
+            projectMembers={projectMembers}
+            selectedUsers={selectedUsers ? selectedUsers.split(',').map((handle) => ({ value: handle, label: handle })) : []}
+            onUpdate={onChange}
+            loggedInUser={loggedInUser}
+          />
 
           <div styleName="btn-selected-members">
-            <button className="tc-btn tc-btn-primary tc-btn-md" 
+            <button className="tc-btn tc-btn-primary tc-btn-md"
               onClick={() => onSubmit(mapHandlesToUserIds(selectedUsers.split(',')))}
               disabled={!selectedUsers || selectedUsers.length === 0 || isSharingAttachment }
             >Share with selected members</button>
@@ -63,11 +68,11 @@ const AddFilePermission = ({ onCancel, onSubmit, onChange, selectedUsers, projec
 }
 
 AddFilePermission.propTypes = {
-  onCancel: PropTypes.func.isRequired, 
-  onSubmit: PropTypes.func.isRequired, 
-  onChange: PropTypes.func.isRequired, 
-  selectedUsers: PropTypes.string, 
-  projectMembers: PropTypes.object, 
+  onCancel: PropTypes.func.isRequired,
+  onSubmit: PropTypes.func.isRequired,
+  onChange: PropTypes.func.isRequired,
+  selectedUsers: PropTypes.string,
+  projectMembers: PropTypes.object,
   loggedInUser: PropTypes.object.isRequired,
   isSharingAttachment: PropTypes.bool.isRequired,
 }
diff --git a/src/components/UserAutoComplete/UserAutoComplete.jsx b/src/components/UserAutoComplete/UserAutoComplete.jsx
index 1c6c61834..7943e4dd5 100644
--- a/src/components/UserAutoComplete/UserAutoComplete.jsx
+++ b/src/components/UserAutoComplete/UserAutoComplete.jsx
@@ -37,7 +37,10 @@ const UserAutoComplete = ({
 
 UserAutoComplete.propTypes = {
   projectMembers: PropTypes.object,
-  selectedUsers: PropTypes.string,
+  selectedUsers: PropTypes.arrayOf(PropTypes.shape({
+    value: PropTypes.string,
+    label: PropTypes.string,
+  })),
   onUpdate: PropTypes.func,
   loggedInUser: PropTypes.object
 }

From dc65e95ef718707aba4138e757041e840578af4e Mon Sep 17 00:00:00 2001
From: Maksym Mykhailenko <maxceem@gmail.com>
Date: Thu, 7 Mar 2019 19:33:35 +0800
Subject: [PATCH 2/4] fix for/htmlFor property and Warning in browser console

---
 src/components/LinksMenu/EditFileAttachment.jsx | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/components/LinksMenu/EditFileAttachment.jsx b/src/components/LinksMenu/EditFileAttachment.jsx
index 525f2c951..95c32cae9 100644
--- a/src/components/LinksMenu/EditFileAttachment.jsx
+++ b/src/components/LinksMenu/EditFileAttachment.jsx
@@ -49,10 +49,10 @@ export class EditFileAttachment extends React.Component {
         You're about to edit an attachment
         </div>
         <div className="modal-body">
-          <label for="title">Title:</label>
+          <label htmlFor="title">Title:</label>
           <input className="edit-input" type="text" value={title} onChange={this.handleTitleChange.bind(this)} name="title"/>
           <br />
-          <label for="title">File Viewers:</label>
+          <label>File Viewers:</label>
           <UserAutoComplete onUpdate={this.onUserIdChange}
             projectMembers={projectMembers}
             loggedInUser={loggedInUser}

From ebb603a061ccb6418d45a8bd5710de8772ccda73 Mon Sep 17 00:00:00 2001
From: Maksym Mykhailenko <maxceem@gmail.com>
Date: Thu, 7 Mar 2019 20:15:14 +0800
Subject: [PATCH 3/4] fix: Cannot choose particular members when updating an
 attachement on the scope page

---
 src/components/FileList/FileListItem.jsx | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/src/components/FileList/FileListItem.jsx b/src/components/FileList/FileListItem.jsx
index 5c2fb962d..1d1ea0cb1 100644
--- a/src/components/FileList/FileListItem.jsx
+++ b/src/components/FileList/FileListItem.jsx
@@ -113,10 +113,11 @@ export default class FileListItem extends React.Component {
         { (errors && errors.title) && <div className="error-message">{ errors.title }</div> }
         <textarea defaultValue={description} ref="desc" maxLength={250} className="tc-textarea" />
         { (errors && errors.desc) && <div className="error-message">{ errors.desc }</div> }
-        <UserAutoComplete onUpdate={this.onUserIdChange}
+        <UserAutoComplete
+          onUpdate={this.onUserIdChange}
           projectMembers={projectMembers}
           loggedInUser={loggedInUser}
-          selectedUsers={this.userIdsToHandles(allowedUsers).join(',')}
+          selectedUsers={this.userIdsToHandles(allowedUsers).map((handle) => ({ value: handle, label: handle }))}
         />
       </div>
     )

From daa5c74e48d0ce74a4a930d4c00bdfb6f26c8d6a Mon Sep 17 00:00:00 2001
From: Maksym Mykhailenko <maxceem@gmail.com>
Date: Thu, 7 Mar 2019 20:16:49 +0800
Subject: [PATCH 4/4] hide project estimation for now

---
 src/projects/create/components/FillProjectDetails.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/projects/create/components/FillProjectDetails.js b/src/projects/create/components/FillProjectDetails.js
index 6a8393837..e76e9d1d5 100644
--- a/src/projects/create/components/FillProjectDetails.js
+++ b/src/projects/create/components/FillProjectDetails.js
@@ -71,7 +71,7 @@ class FillProjectDetails extends Component  {
                     submitBtnText={ submitBtnText }
                     productTemplates={productTemplates}
                   />
-                  <ProjectEstimationSection project={dirtyProject} templates={templates} />
+                  {/* <ProjectEstimationSection project={dirtyProject} templates={templates} /> */}
                 </div>
                 {formDisclaimer && (
                   <div className="left-area-footer">