From a5452e7d7b232297f36f34b2a36ca61e71081e97 Mon Sep 17 00:00:00 2001
From: Muhamad Fikri Alhawarizmi <mfikria@gmail.com>
Date: Thu, 11 Apr 2019 15:40:52 +0700
Subject: [PATCH] use attachment id instead of attachment index

---
 src/components/LinksMenu/FileLinksMenu.jsx        |  2 +-
 .../detail/containers/ProjectInfoContainer.js     | 15 +++++++++------
 2 files changed, 10 insertions(+), 7 deletions(-)

diff --git a/src/components/LinksMenu/FileLinksMenu.jsx b/src/components/LinksMenu/FileLinksMenu.jsx
index c86e93a7f..ba3e57514 100644
--- a/src/components/LinksMenu/FileLinksMenu.jsx
+++ b/src/components/LinksMenu/FileLinksMenu.jsx
@@ -156,7 +156,7 @@ const FileLinksMenu = ({
                 const handleDeleteClick = () => onDeleteIntent(idx)
 
                 const onEditConfirm = (title, allowedUsers) => {
-                  onEdit(idx, title, allowedUsers)
+                  onEdit(link.id, title, allowedUsers)
                   onEditIntent(-1)
                 }
                 const onEditCancel = () => onEditIntent(-1)
diff --git a/src/projects/detail/containers/ProjectInfoContainer.js b/src/projects/detail/containers/ProjectInfoContainer.js
index 78ff8869c..77cec7ea8 100644
--- a/src/projects/detail/containers/ProjectInfoContainer.js
+++ b/src/projects/detail/containers/ProjectInfoContainer.js
@@ -113,17 +113,19 @@ class ProjectInfoContainer extends React.Component {
     })
   }
 
-  onEditAttachment(idx, title, allowedUsers) {
+  onEditAttachment(attachmentId, title, allowedUsers) {
     const { project, updateProjectAttachment } = this.props
     const updatedAttachment = {
       title,
       allowedUsers
     }
-    const attachment = project.attachments[idx]
-    updateProjectAttachment(project.id,
-      attachment.id,
-      updatedAttachment
-    )
+    const attachment = project.attachments.find(attachment => attachment.id === attachmentId)
+    if (attachment) {
+      updateProjectAttachment(project.id,
+        attachment.id,
+        updatedAttachment
+      )
+    }
   }
 
   onDeleteProject() {
@@ -190,6 +192,7 @@ class ProjectInfoContainer extends React.Component {
     }
     attachments = _.sortBy(attachments, attachment => -new Date(attachment.updatedAt).getTime())
       .map(attachment => ({
+        id: attachment.id,
         title: attachment.title,
         address: attachment.downloadUrl,
         allowedUsers: attachment.allowedUsers,