From dcaa881d9c00bbfd4b1f3c68a08b72bed68c0547 Mon Sep 17 00:00:00 2001 From: Vikas Agarwal Date: Sat, 16 Mar 2019 13:10:38 +0530 Subject: [PATCH 1/3] =?UTF-8?q?Github=20issue#2921,=20Cannot=20read=20prop?= =?UTF-8?q?erty=20'title'=20of=20undefined=20=E2=80=94=20Should=20be=20fix?= =?UTF-8?q?ed.=20Root=20cause=20is=20that=20some=20how=20a=20customer=20ro?= =?UTF-8?q?le=20user=20is=20being=20rendered=20in=20the=20topcoder=20team?= =?UTF-8?q?=20dialog.=20However,=20this=20fix=20should=20allow=20graceful?= =?UTF-8?q?=20failing=20in=20such=20situations=20as=20well.?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- src/components/TeamManagement/TopcoderManagementDialog.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/components/TeamManagement/TopcoderManagementDialog.js b/src/components/TeamManagement/TopcoderManagementDialog.js index 32e5e611d..b30ed118f 100644 --- a/src/components/TeamManagement/TopcoderManagementDialog.js +++ b/src/components/TeamManagement/TopcoderManagementDialog.js @@ -172,7 +172,7 @@ class TopcoderManagementDialog extends React.Component { const lastName = _.get(member, 'lastName', '') let userFullName = `${firstName} ${lastName}` userFullName = userFullName.trim().length > 0 ? userFullName : 'Connect user' - const role = _.find(this.roles, r => r.value === member.role).title + const role = _.get(_.find(this.roles, r => r.value === member.role), 'title') return (
Date: Tue, 23 Apr 2019 16:42:50 +0530 Subject: [PATCH 2/3] Github issue#2934, Newest message displays at the top of thread - Moving Add Post text box above the comments to match with the new reversed order of posts --- src/components/Feed/FeedComments.jsx | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/src/components/Feed/FeedComments.jsx b/src/components/Feed/FeedComments.jsx index cab9148a7..6f47bfa52 100644 --- a/src/components/Feed/FeedComments.jsx +++ b/src/components/Feed/FeedComments.jsx @@ -373,16 +373,6 @@ class FeedComments extends React.Component { {(matches) => (matches ? (
-
- {commentRows} - {hasMoreComments && - - } -
{allowComments &&
} +
+ {commentRows} + {hasMoreComments && + + } +
) : (
From d8b3a74a9752c13497a43b5b884daa2fa0f98214 Mon Sep 17 00:00:00 2001 From: Maksym Mykhailenko Date: Tue, 23 Apr 2019 19:50:55 +0800 Subject: [PATCH 3/3] move textarea to the top in the fullscreen post mode --- src/components/Feed/FeedComments.scss | 22 ---------------------- 1 file changed, 22 deletions(-) diff --git a/src/components/Feed/FeedComments.scss b/src/components/Feed/FeedComments.scss index 66c4cfda7..1b3498fa9 100644 --- a/src/components/Feed/FeedComments.scss +++ b/src/components/Feed/FeedComments.scss @@ -21,7 +21,6 @@ &.is-fullscreen { border-radius: 0; - padding-bottom: 62px; } } @@ -158,27 +157,6 @@ .add-comment { background-color: $tc-gray-neutral-light; border-radius: 0 0 $card-border-radius $card-border-radius; - - .is-fullscreen & { - border-top: 1px solid $tc-gray-10; - bottom: 0; - position: fixed; - right: 0; - /* minus sidebar width and minus sidebar border width */ - width: calc(100% - 360px - 1px); - z-index: 5; - - /* if there is not enough space for sidebar to be 360 - than it becomes 1/3 of the width */ - @media screen and (min-width: $screen-md) and (max-width: 360px * 3) { - /* two third of the width minus 1px of the width of the sidebar */ - width: calc(100% / 3 * 2 - 1px); - } - - @media screen and (max-width: $screen-md - 1px) { - width: 100%; - } - } } .no-comments {