This repository was archived by the owner on Jan 23, 2025. It is now read-only.
fix close challenge immediately logic #211
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajefts
reviewed
Jan 22, 2017
| * @param categoryId the category id to look up. | ||
| * @return whether the provided category id should have a project_result row. | ||
| * @since 1.1.4 | ||
| */ |
Contributor
There was a problem hiding this comment.
@skyhit Can we make this config or data driven instead of hardcoding it?
Collaborator
Author
There was a problem hiding this comment.
@ajefts do you want a lookup table for this purpose?
Contributor
There was a problem hiding this comment.
would it make sense to make it a property on project_category_lu? Or a config file that already describes properties based on the challenge types?
Collaborator
Author
There was a problem hiding this comment.
@ajefts yes, add a new property in project_category_lu is more make sense and central for management.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.