-
Notifications
You must be signed in to change notification settings - Fork 6
Migration history fix #43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| LIMIT 1; | ||
|
|
||
| IF idx_schema IS NOT NULL THEN | ||
| EXECUTE format('DROP INDEX %I.%I', idx_schema, 'challenge_phase_order_idx'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[correctness]
Consider using CASCADE with DROP INDEX if there are any dependent objects that might be affected by the index removal. This ensures that the operation does not fail due to dependencies.
| END IF; | ||
|
|
||
| EXECUTE format( | ||
| 'ALTER TABLE %I.%I ALTER COLUMN %I DROP NOT NULL', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[correctness]
Ensure that altering the column to allow nulls does not introduce unintended behavior in the application logic that relies on this column being non-nullable. Consider reviewing the application code for any assumptions about this column's nullability.
| generator client { | ||
| provider = "prisma-client-js" | ||
| previewFeatures = ["fullTextSearchPostgres", "postgresqlExtensions"] | ||
| previewFeatures = ["fullTextSearchPostgres", "postgresqlExtensions", "views"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[maintainability]
Adding views to previewFeatures can introduce instability as preview features are not fully stable. Ensure that this feature is thoroughly tested in your environment before relying on it in production.
| ////////////////////////////////////////// | ||
|
|
||
| model MemberChallengeAccess { | ||
| view MemberChallengeAccess { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[❗❗ correctness]
Changing MemberChallengeAccess from a model to a view can impact how data is queried and manipulated. Ensure that all existing operations on this model are compatible with the view semantics, especially if there are any write operations.
| incrementalCoefficient Float? | ||
| opportunityType ReviewOpportunityTypeEnum? | ||
| isAIReviewer Boolean | ||
| isAIReviewer Boolean? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[❗❗ correctness]
Changing isAIReviewer from Boolean to Boolean? allows for null values, which could lead to unexpected behavior if not handled properly. Ensure that the application logic accounts for potential null values.
No description provided.