Allow for Topgear Submission type phase when calculating start / end … #46
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| const { ensureAcessibilityToModifiedGroups } = require("./group-helper"); | ||
| const { ChallengeStatusEnum } = require("@prisma/client"); | ||
|
|
||
| const SUBMISSION_PHASE_PRIORITY = ["Topcoder Submission", "Submission"]; |
There was a problem hiding this comment.
[💡 maintainability]
Consider adding a comment or documentation explaining the purpose and order of SUBMISSION_PHASE_PRIORITY. This will help future developers understand why these specific phases are prioritized and in this order.
| const registrationPhase = _.find(challenge.phases, (p) => p.name === "Registration"); | ||
| const submissionPhase = _.find(challenge.phases, (p) => p.name === "Submission"); | ||
| const submissionPhase = | ||
| _.find(challenge.phases, (p) => p.name === SUBMISSION_PHASE_PRIORITY[0]) || |
There was a problem hiding this comment.
[correctness]
The logic for finding the submissionPhase relies on the order of SUBMISSION_PHASE_PRIORITY. If additional submission phases are added in the future, ensure they are added to SUBMISSION_PHASE_PRIORITY in the correct order. Consider adding a test case to verify the behavior when multiple submission phases are present.
|
|
||
| const registrationPhase = _.find(phases, (p) => p.name === "Registration"); | ||
| const submissionPhase = | ||
| _.find(phases, (p) => p.name === SUBMISSION_PHASE_PRIORITY[0]) || |
There was a problem hiding this comment.
[performance]
The logic for finding the submissionPhase could be optimized by using a single _.find call with a condition that checks for both phase names in the priority order. This would avoid iterating over the phases array twice.
…dates