Allow for registration phase reopening if submission or TG submission phases are open #48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| }); | ||
|
|
||
| if (dependentOpenPhases.length === 0) { | ||
| const normalizedPhaseName = normalizePhaseName(phaseName); |
There was a problem hiding this comment.
[💡 performance]
The normalizePhaseName function is called twice for each phase in openPhases when checking hasSubmissionVariantOpen. Consider normalizing phase?.name once before the some method to improve performance slightly.
| }) | ||
|
|
||
| try { | ||
| const challengePhase = await service.partiallyUpdateChallengePhase( |
There was a problem hiding this comment.
[correctness]
The try block is missing a catch clause. If service.partiallyUpdateChallengePhase throws an error, it will be silently ignored, which could lead to undetected test failures.
| }) | ||
|
|
||
| try { | ||
| await service.partiallyUpdateChallengePhase(authUser, data.challenge.id, data.challengePhase1Id, { |
There was a problem hiding this comment.
[correctness]
The try block is missing a catch clause. If service.partiallyUpdateChallengePhase throws an error, it will be silently ignored, which could lead to undetected test failures.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://topcoder.atlassian.net/browse/PS-445