From f120a3fab29cc93e7ddb9c66194c31174a54dd6b Mon Sep 17 00:00:00 2001 From: iversonLv Date: Fri, 25 Aug 2017 22:02:13 +0800 Subject: [PATCH 1/4] issue294 -iversonLv- Submission count is not displayed in the tab --- .../components/challenge-detail/Header/TabSelector/index.jsx | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/shared/components/challenge-detail/Header/TabSelector/index.jsx b/src/shared/components/challenge-detail/Header/TabSelector/index.jsx index 43a0bc17ea..c7a4ebdfd4 100644 --- a/src/shared/components/challenge-detail/Header/TabSelector/index.jsx +++ b/src/shared/components/challenge-detail/Header/TabSelector/index.jsx @@ -62,7 +62,7 @@ export default function ChallengeViewSelector(props) { onClick={(e) => { e.preventDefault(); onSelectorClicked('SUBMISSIONS'); }} styleName={getSelectorStyle(selectedView, 'SUBMISSIONS', trackLower)} > - SUBMISSIONS + SUBMISSIONS {numSubmissions ? `(${numSubmissions})` : ''} } { @@ -102,6 +102,7 @@ ChallengeViewSelector.propTypes = { }), checkpointCount: PT.number, numRegistrants: PT.number, + numSubmissions: PT.number, onSelectorClicked: PT.func.isRequired, selectedView: PT.string.isRequired, status: PT.string.isRequired, From d85da50dc2b6acd7186047949ae0717d7355f702 Mon Sep 17 00:00:00 2001 From: iversonLv Date: Mon, 28 Aug 2017 03:13:23 +0800 Subject: [PATCH 2/4] Update index.jsx --- .../components/challenge-detail/Header/TabSelector/index.jsx | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/shared/components/challenge-detail/Header/TabSelector/index.jsx b/src/shared/components/challenge-detail/Header/TabSelector/index.jsx index c7a4ebdfd4..cef62e4f16 100644 --- a/src/shared/components/challenge-detail/Header/TabSelector/index.jsx +++ b/src/shared/components/challenge-detail/Header/TabSelector/index.jsx @@ -61,8 +61,7 @@ export default function ChallengeViewSelector(props) { { e.preventDefault(); onSelectorClicked('SUBMISSIONS'); }} styleName={getSelectorStyle(selectedView, 'SUBMISSIONS', trackLower)} - > - SUBMISSIONS {numSubmissions ? `(${numSubmissions})` : ''} + >SUBMISSIONS {numSubmissions ? `(${numSubmissions})` : ''} } { From 802a8b83af47cff22db97a2f14ac2fd48f94f937 Mon Sep 17 00:00:00 2001 From: iversonLv Date: Mon, 28 Aug 2017 04:21:30 +0800 Subject: [PATCH 3/4] Update index.jsx --- .../components/challenge-detail/Header/TabSelector/index.jsx | 1 + 1 file changed, 1 insertion(+) diff --git a/src/shared/components/challenge-detail/Header/TabSelector/index.jsx b/src/shared/components/challenge-detail/Header/TabSelector/index.jsx index cef62e4f16..3a0820ca37 100644 --- a/src/shared/components/challenge-detail/Header/TabSelector/index.jsx +++ b/src/shared/components/challenge-detail/Header/TabSelector/index.jsx @@ -21,6 +21,7 @@ export default function ChallengeViewSelector(props) { challenge, checkpointCount, numRegistrants, + numSubmissions, onSelectorClicked, selectedView, status, From 0734427704644410821a213017b3e93f4639ee2c Mon Sep 17 00:00:00 2001 From: iversonLv Date: Wed, 30 Aug 2017 04:52:43 +0800 Subject: [PATCH 4/4] Update index.jsx --- .../components/challenge-detail/Header/TabSelector/index.jsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/shared/components/challenge-detail/Header/TabSelector/index.jsx b/src/shared/components/challenge-detail/Header/TabSelector/index.jsx index 3a0820ca37..096243fddf 100644 --- a/src/shared/components/challenge-detail/Header/TabSelector/index.jsx +++ b/src/shared/components/challenge-detail/Header/TabSelector/index.jsx @@ -62,7 +62,7 @@ export default function ChallengeViewSelector(props) { { e.preventDefault(); onSelectorClicked('SUBMISSIONS'); }} styleName={getSelectorStyle(selectedView, 'SUBMISSIONS', trackLower)} - >SUBMISSIONS {numSubmissions ? `(${numSubmissions})` : ''} + >SUBMISSIONS ({numSubmissions}) } {