From 96b9d3302a24ecb32568d6158c98a53f58163d78 Mon Sep 17 00:00:00 2001 From: shubhu Date: Mon, 28 Aug 2017 19:31:41 +0530 Subject: [PATCH 1/2] fixed #366 passing domain for user profiles avatar --- src/shared/components/LeaderboardAvatar/index.jsx | 5 +++-- .../challenge-listing/ChallengeCard/Status/index.jsx | 2 +- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/src/shared/components/LeaderboardAvatar/index.jsx b/src/shared/components/LeaderboardAvatar/index.jsx index 9bc6e7f916..137ecaa0ee 100644 --- a/src/shared/components/LeaderboardAvatar/index.jsx +++ b/src/shared/components/LeaderboardAvatar/index.jsx @@ -1,5 +1,6 @@ // TODO: All uses of this component MUST be replaced by Avatar component! +import config from 'utils/config'; import React, { Component } from 'react'; import PT from 'prop-types'; import './style.scss'; @@ -27,7 +28,7 @@ class LeaderboardAvatar extends Component { render() { const { domain, openNewTab, url } = this.props; const { member } = this.state; - const targetURL = url || `//${domain}/members/${member.handle}`; + const targetURL = url || `${domain}/members/${member.handle}`; return ( - + ); }); From b577ef748922e4250e3c232e976fe5e416b52302 Mon Sep 17 00:00:00 2001 From: shubhu Date: Wed, 30 Aug 2017 12:11:48 +0530 Subject: [PATCH 2/2] get domain via config not props --- src/shared/components/LeaderboardAvatar/index.jsx | 6 ++---- .../challenge-listing/ChallengeCard/Status/index.jsx | 2 +- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/src/shared/components/LeaderboardAvatar/index.jsx b/src/shared/components/LeaderboardAvatar/index.jsx index 137ecaa0ee..b7f0f3a7c3 100644 --- a/src/shared/components/LeaderboardAvatar/index.jsx +++ b/src/shared/components/LeaderboardAvatar/index.jsx @@ -26,9 +26,9 @@ class LeaderboardAvatar extends Component { } render() { - const { domain, openNewTab, url } = this.props; + const { openNewTab, url } = this.props; const { member } = this.state; - const targetURL = url || `${domain}/members/${member.handle}`; + const targetURL = url || `${config.URL.BASE}/members/${member.handle}`; return ( - + ); });