fix(PM-2539): Added timeout to prisma service in member service #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| USERFLOW: process.env.USERFLOW_PRIVATE_KEY | ||
| } | ||
| }, | ||
| MEMBER_SERVICE_PRISMA_TIMEOUT: process.env.MEMBER_SERVICE_PRISMA_TIMEOUT ? parseInt(process.env.MEMBER_SERVICE_PRISMA_TIMEOUT, 10) : 10000, |
There was a problem hiding this comment.
[correctness]
Consider adding validation to ensure process.env.MEMBER_SERVICE_PRISMA_TIMEOUT is a valid integer before parsing it with parseInt. This will prevent potential issues if the environment variable is set to a non-numeric value, which would result in NaN and default to 10000. You can use Number.isInteger() or similar checks for validation.
|
|
||
| const clientOptions = { | ||
| transactionOptions: { | ||
| timeout: config.MEMBER_SERVICE_PRISMA_TIMEOUT, |
There was a problem hiding this comment.
[❗❗ correctness]
Ensure that config.MEMBER_SERVICE_PRISMA_TIMEOUT is properly validated and has a sensible default value. If this value is undefined or set to an inappropriate value, it could lead to unexpected behavior in the transaction timeout.
kkartunov
approved these changes
Oct 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Ticket link - https://topcoder.atlassian.net/browse/PM-2539