From 8e44e462140a074687b19b863cd833d2b8811a8b Mon Sep 17 00:00:00 2001 From: himaniraghav3 Date: Thu, 16 Oct 2025 12:59:21 +0530 Subject: [PATCH] PM-2442 Fix review progress bar --- .../src/lib/hooks/useFetchScreeningReview.ts | 18 ++++++++++++++---- 1 file changed, 14 insertions(+), 4 deletions(-) diff --git a/src/apps/review/src/lib/hooks/useFetchScreeningReview.ts b/src/apps/review/src/lib/hooks/useFetchScreeningReview.ts index 20fbc2271..f69847ff2 100644 --- a/src/apps/review/src/lib/hooks/useFetchScreeningReview.ts +++ b/src/apps/review/src/lib/hooks/useFetchScreeningReview.ts @@ -6,7 +6,7 @@ import { EnvironmentConfig } from '~/config' import { getRatingColor, xhrGetAsync } from '~/libs/core' import { handleError } from '~/libs/shared' -import { REVIEWER, SUBMITTER } from '../../config/index.config' +import { DESIGN, REVIEWER, SUBMITTER } from '../../config/index.config' import { ChallengeDetailContext, ReviewAppContext } from '../contexts' import { BackendPhase, @@ -2161,7 +2161,17 @@ export function useFetchScreeningReview(): useFetchScreeningReviewProps { return 0 } - const completedReviews = filter(review, item => { + const isDesignChallenge = challengeInfo?.track.name === DESIGN + + const filteredReviews = isDesignChallenge + ? review + : review.filter(item => item.isLatest) + + if (!filteredReviews.length) { + return 0 + } + + const completedReviews = filteredReviews.filter(item => { const committed = item.review?.committed if (typeof committed === 'boolean') { return committed @@ -2185,9 +2195,9 @@ export function useFetchScreeningReview(): useFetchScreeningReviewProps { }) return Math.round( - (completedReviews.length * 100) / review.length, + (completedReviews.length * 100) / filteredReviews.length, ) - }, [review]) + }, [review, challengeInfo]) useEffect(() => () => { cancelLoadResourceAppeal()