Skip to content

PM-2921 - fix screener multiple submissions showing up #1336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 25, 2025
Merged

PM-2921 - fix screener multiple submissions showing up #1336

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6cb9474
PM-2921 - fix screener multiple submissions showing up
vas3a Nov 25, 2025
925d190
lint fix
vas3a Nov 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/apps/review/src/lib/components/SubmissionHistoryModal/SubmissionHistoryModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,8 @@ export const SubmissionHistoryModal: FC<SubmissionHistoryModalProps> = (props: S
[props.submissions],
)

const aiReviewersCount = useMemo(() => (props.aiReviewers?.length ?? 0) + 1, [props.aiReviewers])
const aiReviewers = useMemo(() => props.aiReviewers ?? [], [props.aiReviewers])
const aiReviewersCount = useMemo(() => (aiReviewers.length ?? 0) + 1, [aiReviewers])

const [toggledRows, setToggledRows] = useState(new Set<string>())

Expand Down Expand Up @@ -279,7 +280,7 @@ export const SubmissionHistoryModal: FC<SubmissionHistoryModalProps> = (props: S
<td className={styles.aiReviewersTableRow} colSpan={4}>
<div className={styles.aiReviewersTable}>
<AiReviewsTable
reviewers={props.aiReviewers!}
reviewers={aiReviewers}
submission={submission}
/>
</div>
Expand Down
9 changes: 7 additions & 2 deletions src/apps/review/src/lib/components/TableSubmissionScreening/TableSubmissionScreening.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -802,13 +802,18 @@ export const TableSubmissionScreening: FC<Props> = (props: Props) => {
[historySourceSubmissions, primarySubmissionInfos],
)

const { historyByMember }: SubmissionHistoryPartition = submissionHistory
const { historyByMember, latestSubmissionIds }: SubmissionHistoryPartition = submissionHistory

const shouldShowHistoryActions = useMemo(
() => hasIsLatestFlag(primarySubmissionInfos),
[primarySubmissionInfos],
)

const filteredScreenings = useMemo(() => (
props.screenings
.filter(screening => latestSubmissionIds.has(screening.submissionId))
), [props.screenings, latestSubmissionIds])

const hasAnyScreeningAssignment = useMemo(
() => props.screenings.some(screening => Boolean(screening.myReviewResourceId)),
[props.screenings],
Expand Down Expand Up @@ -1172,7 +1177,7 @@ export const TableSubmissionScreening: FC<Props> = (props: Props) => {
) : (
<Table
columns={columns}
data={props.screenings}
data={filteredScreenings}
disableSorting
onToggleSort={_.noop}
removeDefaultSort
Expand Down
Loading