From 36f27b32620cc207906de68a9affe7d5d32032d4 Mon Sep 17 00:00:00 2001 From: Hentry Martin Date: Fri, 12 Dec 2025 21:20:29 +0100 Subject: [PATCH 1/2] fix: dont show edit manager comment to reviewer and filter reviews which are failed screening --- .../ChallengeDetailsContent.tsx | 1 + .../ChallengeDetailsContent/TabContentReview.tsx | 6 ++++++ .../ReviewManagerComment/ReviewManagerComment.tsx | 2 +- .../src/lib/components/TableReview/TableReview.tsx | 12 ++++++++++-- 4 files changed, 18 insertions(+), 3 deletions(-) diff --git a/src/apps/review/src/lib/components/ChallengeDetailsContent/ChallengeDetailsContent.tsx b/src/apps/review/src/lib/components/ChallengeDetailsContent/ChallengeDetailsContent.tsx index 69033a337..baaa79adf 100644 --- a/src/apps/review/src/lib/components/ChallengeDetailsContent/ChallengeDetailsContent.tsx +++ b/src/apps/review/src/lib/components/ChallengeDetailsContent/ChallengeDetailsContent.tsx @@ -508,6 +508,7 @@ export const ChallengeDetailsContent: FC = (props: Props) => { selectedTab={props.selectedTab} reviews={reviewTabReviews} submitterReviews={reviewTabSubmitterReviews} + screeningOutcome={screeningOutcome} reviewMinimumPassingScore={props.reviewMinimumPassingScore} isLoadingReview={props.isLoadingSubmission} isDownloading={isDownloadingSubmission} diff --git a/src/apps/review/src/lib/components/ChallengeDetailsContent/TabContentReview.tsx b/src/apps/review/src/lib/components/ChallengeDetailsContent/TabContentReview.tsx index 8efcb4805..25721f38b 100644 --- a/src/apps/review/src/lib/components/ChallengeDetailsContent/TabContentReview.tsx +++ b/src/apps/review/src/lib/components/ChallengeDetailsContent/TabContentReview.tsx @@ -46,6 +46,10 @@ import { hasSubmitterPassedThreshold } from '../../utils/reviewScoring' interface Props { aiReviewers?: { aiWorkflowId: string }[] selectedTab: string + screeningOutcome: { + failingSubmissionIds: Set; + passingSubmissionIds: Set; + } reviews: SubmissionInfo[] submitterReviews: SubmissionInfo[] reviewMinimumPassingScore?: number | null @@ -636,6 +640,7 @@ export const TabContentReview: FC = (props: Props) => { }, [resolvedReviewsWithSubmitter], ) + const filteredSubmitterReviews = useMemo( () => { if (!resolvedSubmitterReviews.length) { @@ -729,6 +734,7 @@ export const TabContentReview: FC = (props: Props) => { = props => {
- {isManagerEdit && ( + {isManagerEdit && canAddManagerComment && (