From b8d54e60287ed62d4a64730ceacf447346c2aef0 Mon Sep 17 00:00:00 2001 From: Vasilica Olariu Date: Mon, 29 Aug 2022 13:46:23 +0300 Subject: [PATCH 1/2] TCA-366 - Certificate view is flickering when trackType isn't DEV --- .../certificate-view/CertificateView.tsx | 8 ++++++-- .../certificate-bg-pattern/CertificateBgPattern.tsx | 3 ++- 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/src-ts/tools/learn/course-certificate/certificate-view/CertificateView.tsx b/src-ts/tools/learn/course-certificate/certificate-view/CertificateView.tsx index 465c19982..ead6c3bab 100644 --- a/src-ts/tools/learn/course-certificate/certificate-view/CertificateView.tsx +++ b/src-ts/tools/learn/course-certificate/certificate-view/CertificateView.tsx @@ -66,7 +66,11 @@ const CertificateView: FC = (props: CertificateViewProps) const { certification: certificate, ready: certificateReady, - }: AllCertificationsProviderData = useAllCertifications(props.provider, course?.certificationId) + }: AllCertificationsProviderData = useAllCertifications( + props.provider, + course?.certificationId, + {enabled: !!course?.certificationId} + ) const ready: boolean = useMemo(() => ( completedCertificateReady && courseReady && certificateReady @@ -142,7 +146,7 @@ const CertificateView: FC = (props: CertificateViewProps) <> - {readyAndCompletedCertification && ( + {ready && readyAndCompletedCertification && (
{!props.hideActions && ( diff --git a/src-ts/tools/learn/course-certificate/certificate-view/certificate/certificate-bg-pattern/CertificateBgPattern.tsx b/src-ts/tools/learn/course-certificate/certificate-view/certificate/certificate-bg-pattern/CertificateBgPattern.tsx index f1d2196b7..596ef86e9 100644 --- a/src-ts/tools/learn/course-certificate/certificate-view/certificate/certificate-bg-pattern/CertificateBgPattern.tsx +++ b/src-ts/tools/learn/course-certificate/certificate-view/certificate/certificate-bg-pattern/CertificateBgPattern.tsx @@ -1,10 +1,11 @@ import classNames from 'classnames' import { FC } from 'react' +import { LearnCertificateTrackType } from '../../../../learn-lib' import styles from './CertificateBgPattern.module.scss' interface CertificateBgPatternProps { - type: 'QA'|'DEV'|'DATASCIENCE'|'DESIGN' + type: LearnCertificateTrackType } const CertificateBgPattern: FC = (props: CertificateBgPatternProps) => { From a2e92aa3b904b2ceff75edcdb89b6ba9f4c558df Mon Sep 17 00:00:00 2001 From: Vasilica Olariu Date: Mon, 29 Aug 2022 14:15:01 +0300 Subject: [PATCH 2/2] lint fixes --- .../certificate/certificate-bg-pattern/CertificateBgPattern.tsx | 1 + 1 file changed, 1 insertion(+) diff --git a/src-ts/tools/learn/course-certificate/certificate-view/certificate/certificate-bg-pattern/CertificateBgPattern.tsx b/src-ts/tools/learn/course-certificate/certificate-view/certificate/certificate-bg-pattern/CertificateBgPattern.tsx index 596ef86e9..82fdb7c1a 100644 --- a/src-ts/tools/learn/course-certificate/certificate-view/certificate/certificate-bg-pattern/CertificateBgPattern.tsx +++ b/src-ts/tools/learn/course-certificate/certificate-view/certificate/certificate-bg-pattern/CertificateBgPattern.tsx @@ -2,6 +2,7 @@ import classNames from 'classnames' import { FC } from 'react' import { LearnCertificateTrackType } from '../../../../learn-lib' + import styles from './CertificateBgPattern.module.scss' interface CertificateBgPatternProps {