Skip to content

Prod 3245 Integrate Self-Service Challenges, Support, Settings, Footer -> TCA-3115_uni-nav #427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Nov 23, 2022
Merged

Prod 3245 Integrate Self-Service Challenges, Support, Settings, Footer -> TCA-3115_uni-nav #427

merged 6 commits into from
Nov 23, 2022

Conversation

@brooketopcoder
Copy link
Contributor

@brooketopcoder brooketopcoder commented Nov 23, 2022 •
edited
Loading

This PR updates routing for the uni-nav for the following tools/utils:

  • Self-service Challenges /work
  • Account Settings /account
  • Contact Support /support
  • Footer

It also:

  • removes the customer- and member-specific top nav
  • adds IDs to the routes so we can ID them separately from the title and the titles don't need to be unique
  • sets the self-service tool to use the same tool name for all its pages

@brooketopcoder
Merge branch 'PROD-3246_update-user' into PROD-3245_work
20600a2
@brooketopcoder
PROD-3245 #comment This commit adds the universal footer and removes …
f6cdd2c 
…the existing footer #time 15m
@brooketopcoder
Merge branch 'PROD-3115_handle-navigation' into PROD-3245_work
4203971
@brooketopcoder
Merge branch 'PROD-3115_handle-navigation' into PROD-3245_work
c3d60e2
@brooketopcoder
PROD-3245 #comment This commit removes the customer- and member-speci…
6425c9f 
…fic top nav. It also adds IDs to the routes so we can ID them separately from the title and the titles don't need to be unique. Finally, it sets the self-service tool to use the same tool name for all its pages. #time 2h
@brooketopcoder brooketopcoder changed the base branch from PROD-3115_uni-nav to dev November 23, 2022 17:56
@brooketopcoder brooketopcoder changed the base branch from dev to PROD-3115_uni-nav November 23, 2022 17:56
@brooketopcoder brooketopcoder changed the title Prod 3245 Integrate Self-Service Challenges, Support, Settings -> TCA-3115_uni-nav Prod 3245 Integrate Self-Service Challenges, Support, Settings, Footer -> TCA-3115_uni-nav Nov 23, 2022
@brooketopcoder brooketopcoder self-assigned this Nov 23, 2022
vas3a
vas3a approved these changes Nov 23, 2022
View reviewed changes
Copy link
Collaborator

@vas3a vas3a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@brooketopcoder brooketopcoder merged commit b158852 into PROD-3115_uni-nav Nov 23, 2022
@brooketopcoder brooketopcoder deleted the PROD-3245_work branch November 23, 2022 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vas3a vas3a vas3a approved these changes

@testflyjets testflyjets Awaiting requested review from testflyjets

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@brooketopcoder @vas3a