Skip to content

Onboarding #810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 20, 2023
Merged

Onboarding #810

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
57c5a6c
The Tab key is not opening the drop downs in Education and Experience…
suppermancool Jul 20, 2023
6b68c3c
Merge pull request #809 from topcoder-platform/issue-808
jmgasper Jul 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/libs/ui/lib/components/form/form-groups/form-input/input-select/InputSelect.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ import {
ChangeEvent,
Dispatch,
FC,
FocusEvent,
MouseEvent,
MutableRefObject,
ReactNode,
Expand Down Expand Up @@ -83,13 +84,19 @@ const InputSelect: FC<InputSelectProps> = (props: InputSelectProps) => {
className={styles['select-input-wrapper']}
hideInlineErrors={props.hideInlineErrors}
ref={triggerRef}
forceFocusStyle={menuIsVisible}
>
<button
tabIndex={props.tabIndex}
className={styles.selected}
onClick={toggleIfNotDisabled}
type='button'
disabled={!!props.disabled}
onFocus={function onFocus(event: FocusEvent<HTMLButtonElement> | undefined) {
event?.stopPropagation()
event?.preventDefault()
setMenuIsVisible(true)
}}
>
<span className='body-small'>{selectedOption ? label(selectedOption) : ''}</span>
<span className='body-small'>{!selectedOption && !!props.placeholder ? props.placeholder : ''}</span>
Expand Down
4 changes: 4 additions & 0 deletions src/libs/ui/lib/components/form/form-groups/form-input/input-wrapper/InputWrapper.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ interface InputWrapperProps {
readonly label: string | JSX.Element
readonly tabIndex?: number
readonly type: 'checkbox' | 'password' | 'rating' | 'text' | 'textarea'
readonly forceFocusStyle?: boolean
}

const InputWrapper: ForwardRefExoticComponent<InputWrapperProps & { ref?: React.Ref<HTMLDivElement> }>
Expand All @@ -43,6 +44,9 @@ const InputWrapper: ForwardRefExoticComponent<InputWrapperProps & { ref?: React.
focusStyle,
showError ? styles['input-error'] : undefined,
props.className,
{
[styles.focus]: props.forceFocusStyle,
},
)

const renderCheckboxLabel: () => JSX.Element | boolean = () => props.type === 'checkbox' && (
Expand Down