fix(PM-2539): added timeout for prisma client #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| inviteEmailSubject: process.env.INVITE_EMAIL_SUBJECT || 'You are invited to Topcoder', | ||
| inviteEmailSectionTitle: process.env.INVITE_EMAIL_SECTION_TITLE || 'Project Invitation', | ||
| SSO_REFCODES: process.env.SSO_REFCODES || '[]', | ||
| PROJECT_SERVICE_PRISMA_TIMEOUT: process.env.PROJECT_SERVICE_PRISMA_TIMEOUT ? parseInt(process.env.PROJECT_SERVICE_PRISMA_TIMEOUT) : 10000 |
There was a problem hiding this comment.
[correctness]
Consider using Number() instead of parseInt() for parsing PROJECT_SERVICE_PRISMA_TIMEOUT. parseInt() can produce unexpected results if the environment variable contains non-numeric characters, whereas Number() will return NaN in such cases, which might be safer for ensuring the timeout is a valid number.
| constructor() { | ||
| super({ | ||
| transactionOptions: { | ||
| timeout: AppConfig.PROJECT_SERVICE_PRISMA_TIMEOUT, |
There was a problem hiding this comment.
[❗❗ correctness]
Ensure that AppConfig.PROJECT_SERVICE_PRISMA_TIMEOUT is validated and has a sensible default value to prevent potential runtime errors or unintended behavior if the configuration is missing or incorrect.
kkartunov
approved these changes
Oct 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Ticket link - https://topcoder.atlassian.net/browse/PM-2539