More performance updates #133
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| ]; | ||
|
|
||
| const joinClause = joinSqlFragments( | ||
| [...baseJoins, ...metricJoins], |
There was a problem hiding this comment.
[correctness]
The joinSqlFragments function is used to concatenate SQL fragments without a separator. Ensure that this is intentional and that no separator is needed between the baseJoins and metricJoins. If a separator is required, this could lead to incorrect SQL syntax.
| [...baseJoins, ...metricJoins], | ||
| Prisma.sql``, | ||
| ); | ||
| const countJoinClause = joinSqlFragments(baseJoins, Prisma.sql``); |
There was a problem hiding this comment.
[correctness]
The countJoinClause only includes baseJoins. Verify that excluding metricJoins from the count query is intentional. If metrics affect the count, this could lead to incorrect results.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.