Use legacy scorecard ID as a fallback for legacy data #137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| }, | ||
| }; | ||
|
|
||
| const scorecardById = await this.prisma.scorecard.findUnique({ |
There was a problem hiding this comment.
[maintainability]
Consider using findUniqueOrThrow instead of findUnique for scorecardById to automatically throw an error if the scorecard is not found. This would simplify the logic by removing the need for the subsequent if (scorecardById) check.
| return scorecardById as ScorecardWithGroupResponseDto; | ||
| } | ||
|
|
||
| const scorecardByLegacyId = await this.prisma.scorecard.findFirst({ |
There was a problem hiding this comment.
[❗❗ correctness]
The use of findFirst for scorecardByLegacyId could potentially return an incorrect scorecard if multiple scorecards have the same legacyId. Ensure that legacyId is unique or adjust the logic to handle multiple matches appropriately.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.