Skip to content

Debug in PROD #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 2, 2025
Merged

Debug in PROD #148

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ba7a201
add debug logs
kkartunov Nov 2, 2025
b027855
moer debug
kkartunov Nov 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/shared/modules/global/resource.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,14 @@ export class ResourceApiService {
while (true) {
params.set('page', String(page));

this.logger.log(
Copy link

@github-actions github-actions bot Nov 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[❗❗ security]
Logging sensitive information such as query.challengeId and query.memberId can pose security risks. Consider removing these from the logs or ensure they are adequately protected.

'Debug resources call:',
params.toString(),
Copy link

@github-actions github-actions bot Nov 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[💡 readability]
The params.toString() and JSON.stringify(params) might produce redundant information in the logs. Consider logging only the necessary details to avoid clutter.

JSON.stringify(params),
query.challengeId,
query.memberId,
);

const url = `${CommonConfig.apis.resourceApiUrl}resources?${params.toString()}`;
const response = await firstValueFrom(
this.httpService.get<ResourceInfo[]>(url, {
Expand Down