From 512d94624f129b3a314ed732357e7a91e1cd08cb Mon Sep 17 00:00:00 2001 From: Vasilica Olariu Date: Tue, 16 Sep 2025 14:12:04 +0300 Subject: [PATCH] Fix data comparison --- src/api/ai-workflow/ai-workflow.controller.ts | 2 ++ src/api/ai-workflow/ai-workflow.service.ts | 4 ++-- src/shared/modules/global/resource.service.ts | 2 +- 3 files changed, 5 insertions(+), 3 deletions(-) diff --git a/src/api/ai-workflow/ai-workflow.controller.ts b/src/api/ai-workflow/ai-workflow.controller.ts index e9357d4..57188f5 100644 --- a/src/api/ai-workflow/ai-workflow.controller.ts +++ b/src/api/ai-workflow/ai-workflow.controller.ts @@ -122,6 +122,7 @@ export class AiWorkflowController { UserRole.ProjectManager, UserRole.Reviewer, UserRole.Submitter, + UserRole.User, ) @Scopes(Scope.ReadWorkflowRun) @ApiOperation({ @@ -154,6 +155,7 @@ export class AiWorkflowController { UserRole.ProjectManager, UserRole.Reviewer, UserRole.Submitter, + UserRole.User, ) @Scopes(Scope.ReadWorkflowRun) @ApiOperation({ diff --git a/src/api/ai-workflow/ai-workflow.service.ts b/src/api/ai-workflow/ai-workflow.service.ts index 7ff5ed5..83d8353 100644 --- a/src/api/ai-workflow/ai-workflow.service.ts +++ b/src/api/ai-workflow/ai-workflow.service.ts @@ -320,7 +320,7 @@ export class AiWorkflowService { ).filter((resource) => requiredRoles.some( (role) => - resource.roleName!.toLowerCase().indexOf(role.toLowerCase()) >= 0, + resource.roleName!.toLowerCase() === role.toLowerCase(), ), ); @@ -333,7 +333,7 @@ export class AiWorkflowService { memberRoles.some( (r) => r.roleName?.toLowerCase() === UserRole.Submitter.toLowerCase(), ) && - user.userId !== submission.memberId + String(user.userId) !== String(submission.memberId) ) { this.logger.log( `Submitter ${user.userId} trying to access AI workflow run for other submitters.`, diff --git a/src/shared/modules/global/resource.service.ts b/src/shared/modules/global/resource.service.ts index 6cb4939..21f23a4 100644 --- a/src/shared/modules/global/resource.service.ts +++ b/src/shared/modules/global/resource.service.ts @@ -104,7 +104,7 @@ export class ResourceApiService { memberId: memberId, }) ) - .filter((resource) => resource.memberId === memberId) + .filter((resource) => String(resource.memberId) === String(memberId)) .map((resource) => ({ ...resource, roleName: resourceRoles?.[resource.roleId]?.name ?? '',