Skip to content

fix issue 1334 #1335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 11, 2022
Merged

fix issue 1334 #1335

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 3 additions & 12 deletions src/components/ChallengeEditor/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1239,16 +1239,8 @@ class ChallengeEditor extends Component {
* Check if current phase is active for edit
*/
isPhaseEditable (phaseIndex) {
const { challenge } = this.state
const { phases, currentPhaseNames } = challenge

let currentIndex = phases.findIndex((item) => {
return item.name !== 'Registration' && currentPhaseNames.includes(item.name) && item.isOpen
})

if (currentIndex === -1 || currentIndex > phaseIndex) return false

return true
const { phases } = this.state.challenge
return moment(phases[phaseIndex].scheduledEndDate).isAfter(moment())
}

render () {
Expand Down Expand Up @@ -1612,8 +1604,7 @@ class ChallengeEditor extends Component {
phase={phase}
phaseIndex={uuidv4()}
readOnly={false}
// isActive={this.isPhaseEditable(index)}
isActive
isActive={this.isPhaseEditable(index)}
onUpdatePhase={(item) => {
if ((item.startDate && !moment(item.startDate).isSame(phase.scheduledStartDate)) ||
(item.endDate && !moment(item.endDate).isSame(phase.scheduledEndDate))
Expand Down