Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lift function can't handle NAs #225

Closed
MarwaNabil opened this issue Aug 19, 2015 · 2 comments
Closed

Lift function can't handle NAs #225

MarwaNabil opened this issue Aug 19, 2015 · 2 comments
Labels
bug

Comments

@MarwaNabil
Copy link

@MarwaNabil MarwaNabil commented Aug 19, 2015

I am trying to evaluate different models using Lift chart. The different model predictions have different length. So combining them all results in some rows with NA,as shown below,
X Model-A Model-B
1 0.7 NA
2 NA 0.6

This results in NA values in computed lift values. Is there any way to remove NAs of different models through the evaluation steps?

Thanks.

@topepo topepo added the bug label Aug 20, 2015
@topepo
Copy link
Owner

@topepo topepo commented Aug 20, 2015

That sounds like a bug. I'll try to come up with a fix soon.

topepo added a commit that referenced this issue Sep 3, 2015
@topepo
Copy link
Owner

@topepo topepo commented Sep 3, 2015

fixed.

@topepo topepo closed this Sep 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.