Skip to content

/ caret

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix rfe class probability logic #234

Closed
topepo opened this issue Aug 30, 2015 · 1 comment
Closed

fix rfe class probability logic #234

topepo opened this issue Aug 30, 2015 · 1 comment
Labels
bug next release

Comments

@topepo
Copy link
Owner

@topepo topepo commented Aug 30, 2015

Change this inside of the caretFuncs$pred:

    if (object$modelType == "Classification" & !is.null(object$modelInfo$prob)) {
        out <- cbind(data.frame(pred = tmp), as.data.frame(predict(object, x, type = "prob")))
    }

This should use object$control$classProbs instead.
topepo added a commit that referenced this issue Sep 3, 2015
@topepo
change to fix issue #234
Loading status checks…
0b56b0b
topepo added a commit that referenced this issue Sep 3, 2015
@topepo
misc changes
Loading status checks…
3eae54e 
* updates to the package checking logic for python models
* removal of lfda man files
* updates to `preProcess`
* `rfe` changes related to issue #234
* version/date update
topepo added a commit that referenced this issue Sep 3, 2015
@topepo
additional test for issue #234
Loading status checks…
4003c6e
@topepo
Copy link
Owner Author

@topepo topepo commented Sep 3, 2015

changes made and test cases added
@topepo topepo closed this Sep 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug next release
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
@topepo
You can’t perform that action at this time.