Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RDA parameter mistake #369

Closed
eric-czech opened this issue Feb 9, 2016 · 1 comment
Closed

RDA parameter mistake #369

eric-czech opened this issue Feb 9, 2016 · 1 comment

Comments

@eric-czech
Copy link

@eric-czech eric-czech commented Feb 9, 2016

I believe the following line in models/files/rda.R is mistaken:

fit = function(x, y, wts, param, lev, last, classProbs, ...) {
    klaR:::rda(x, y, gamma = param$gamma, param = tuneValue$lambda, ...)
}

Should that not read like this instead?

fit = function(x, y, wts, param, lev, last, classProbs, ...) {
    klaR:::rda(x, y, gamma = param$gamma, lambda = param$lambda, ...)
}
@topepo
Copy link
Owner

@topepo topepo commented Feb 10, 2016

That is correct. I'm fixing it now.

Thanks,

Max

topepo added a commit that referenced this issue Feb 10, 2016
topepo added a commit that referenced this issue Feb 10, 2016
@topepo topepo closed this Feb 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.